-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try reducing the component hierarchy for Group block #1485
Labels
Comments
pinarol
changed the title
Try reducing the component hierarchy in Group block
Try reducing the component hierarchy for Group block
Oct 23, 2019
3 tasks
I think the new bordering logic helped us make this better, so closing this or now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We are facing with a crash when we nest too much in the Group block.
The root cause analysis made by @dratwas shows that the crash is related with the following line where there's a max limit in calculating layout:
https://href.li/?https://github.com/facebook/react-native/blob/master/React/Views/RCTShadowView.m#L156-L182
We should try to address that issue separately, but apart from that, let's also take a look inside our code and see if there's unnecessary layers in the component hierarchy. block-list/block.native.js looks especially worth investigating about this.
The text was updated successfully, but these errors were encountered: