-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendoring build/lambda/
files
#7
Comments
I have an interpreter that I wrote by myself which I can include in this repo, except it's written in Haskell, so it would create a Haskell dependency. Would that still help? |
Hmm, probably not I'm afraid |
I see. I'll be adding existence checks before wget. Would throwing an error if the files are nonexistent be enough? |
I think so, as long as it would skip the wget in those cases, probably should be good |
I tried running wget with a nonexistent URL (returns 404), and it returned a nonzero return code. Running it within a Makefile stopped the Make process at wget. So essentially, there's already an existence check in wget, since if the URL starts returning a 404 it would stop Make. I could add |
Wait no, sorry, I'm pretty sure I got confused. What I need is for it to check if the file already exists, and if it does, skip wget. The problem right now is that we wanna provide those files ourselves, because we can't have network access, and when we try to use make it fails because it tries to reach the internet. Sorry for the confusion! |
Oh I see! No problem, thanks for the clarification. In that case, the local existence check is done by the Makefile itself. Right now, the recipe for "making" the interpreter source files (*.c) is to wget it. So if *.c already exists, So to prevent |
Ohh I see, I'll try that, thanks! |
Hi, over at NixOS/nixpkgs#242101 (review), we wanted to make use of the make file more directly when building lambda-lisp.
It would be very helpful if lambdalisp could vendor those files, or at least check for their existence before calling
wget
, as we can't make network requests from the nix sandbox.The text was updated successfully, but these errors were encountered: