Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'disableClock' prop #10

Closed
wants to merge 1 commit into from
Closed

Add 'disableClock' prop #10

wants to merge 1 commit into from

Conversation

twinraven
Copy link

@twinraven twinraven commented Aug 22, 2018 •
edited
Loading

Hi @wojtekmaj, would it be possible to add the disableClock prop to this repo too, as we did with
wojtekmaj/react-datetime-picker?

Potentially closes #9

@wojtekmaj
Copy link
Owner

Haha, oh man! I expanded the fix to all libraries which uses React-Clock, but I forgot to push it :D
If I may, I'll close this one to avoid merge conflicts, although it's almost exactly the same code :)

I'd like to thank you for your contribution though - I really appreciate it!

@wojtekmaj wojtekmaj closed this Aug 23, 2018
@wojtekmaj wojtekmaj added the enhancement New feature or request label Aug 23, 2018
@wojtekmaj wojtekmaj added this to the 2.7.0 milestone Aug 23, 2018
@wojtekmaj wojtekmaj self-assigned this Aug 23, 2018
@twinraven twinraven deleted the disable-clock branch August 23, 2018 08:56
@twinraven
Copy link
Author

ha - awesome :) no worries!

@wojtekmaj wojtekmaj modified the milestones: 2.7.0, 2.6.0 Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wojtekmaj wojtekmaj

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

How to disable <Clock/> component?
2 participants
@twinraven @wojtekmaj