Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minTime and maxTime doesn't work... #75

Closed
bluego78 opened this issue Jan 23, 2020 · 7 comments
Closed

minTime and maxTime doesn't work... #75

bluego78 opened this issue Jan 23, 2020 · 7 comments
Labels
bug Something isn't working stale

Comments

@bluego78
Copy link

minTime and maxTime doesn't work...
if you set a new Date() or a string like "07:00:00" not working.

@anniekfifer
Copy link

Also experiencing this issue as of recently but not sure for how long. Reproduced using both Date and string inputs, in military format with and without seconds.

@toto22450
Copy link

Is there any update on this issue ?

@eglorenzana
Copy link

eglorenzana commented Oct 19, 2020

I also have this issue in version 2.8.
I updated directly to version 4.0.1 and it seems to be working.

UPDATE

Trying in version 4.0.1, the input has the attributes min and max accordingly with the minTime prop.

  • Using key up and key down work fine.
  • If the value is modified by typing the number itself, and by doing that the value results in a non-valid time, the onChange event is not triggered (docs describe onChange event is triggered for valid date only)

Since min and max are set correctly, I am using the :invalid css selector to make the invalid time noticeable, but I haven't find a way to report the error from an event

@marcosilvestroni
Copy link

as @eglorenzana reported this bug cannot intercept the error why not add an onError callback? for manage this situation?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2021

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this issue will be closed in 14 days.

@github-actions github-actions bot added the stale label Sep 6, 2021
@github-actions
Copy link
Contributor

This issue was closed because it has been stalled for 14 days with no activity.

@wojtekmaj wojtekmaj added the bug Something isn't working label Sep 20, 2021
@youbek
Copy link

youbek commented Oct 26, 2021

Agree with @marcosilvestroni. We definitely need an onError callback, for example, I want to disable the Form button when there is invalid input in TimePicker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

7 participants