Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many 0 digits in smallest increment input is not triggering error state #51

Closed
emilyuhde opened this issue Aug 8, 2019 · 4 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists stale

Comments

@emilyuhde
Copy link
Contributor

emilyuhde commented Aug 8, 2019

If you have a TimePicker with hours and minutes and you want to enter 10:00, enter 10 into the hours input, the TimePicker will move you to the mintes input, then type in 00. After you type the first 0, a leadering 0 is automatically added, but when you type in your next 0, you will have too many digits in the minutes input (000) but the error state isn't triggered. This also happens if you enter other digits after your 0s, say 0001 or 0011. It only triggers the error state for non-zero numbers with too many digits from what I can tell, such as 000111, 0111 or 111.

Screen Shot 2019-08-08 at 3 43 28 PM

Screen Shot 2019-08-08 at 3 43 35 PM

Screen Shot 2019-08-08 at 3 43 40 PM

Screen Shot 2019-08-08 at 3 43 44 PM

@emilyuhde
Copy link
Contributor Author

It would be nice if there was a max length set on the smallest increment of time a TimePicker uses in this case minutes, to avoid the issue by not even allowing more than two digits to be entered in each part of the time.

@wojtekmaj
Copy link
Owner

Kinda duplicate of #45 / #87.

Since the latter just have been fixed, I believe this issue should be fixed fully in v4.2.0.

@wojtekmaj wojtekmaj added bug Something isn't working duplicate This issue or pull request already exists labels Mar 10, 2021
@github-actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this issue will be closed in 14 days.

@github-actions github-actions bot added the stale label Sep 27, 2021
@github-actions
Copy link
Contributor

This issue was closed because it has been stalled for 14 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists stale
Projects
None yet
Development

No branches or pull requests

2 participants