Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge browser: intermittent flicking of blue focus state color on click of an input #37

Closed
emilyuhde opened this issue Jun 24, 2019 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@emilyuhde
Copy link
Contributor

When using the react-time-picker in Edge, if you click onto one of the inputs (hour, minute, second) the text will highlight in dark blue and then it will quickly disappear and you will see your cursor inside of the input. This does not happen consistently, but it happens often. I belive the dark blue text highlighting is a focus state in Edge. If you go to the dev tools and apply the "focus" artificial state to one of the inputs, you will see the same blue text highlighting appear.

This isn't a major issue, it isn't breaking anything, but it is a little strange looking.

@emilyuhde emilyuhde changed the title Edge browser: itermittent flicking of blue focus state color on click on an input Edge browser: intermittent flicking of blue focus state color on click of an input Jun 24, 2019
@wojtekmaj
Copy link
Owner

Oh my, you're now a full-time React-Time-Picker tester! 💪

Would you mind specifying Edge version? I have plenty, and Chromium-based Edge didn't make it any easier :D

@wojtekmaj wojtekmaj self-assigned this Jun 27, 2019
@wojtekmaj wojtekmaj added the bug Something isn't working label Jun 27, 2019
@wojtekmaj
Copy link
Owner

Note to self: Likely to be happening in React-Date-Picker too, check & fix everywhere

@emilyuhde
Copy link
Contributor Author

I know, I feel kind of bad filing so many issues!

I see this issue on:
Edge 41.16299.1004.0
Microsoft EdgeHTML 16.16299

@wojtekmaj
Copy link
Owner

That's not bad at all! I'm happy to have someone QA-ing my work this actively :) Obviously it's challenging for me to be the judge of my own creations.

Working on 🍎 right now so I will check this issue on Windows in the evening. Thanks!

@emilyuhde
Copy link
Contributor Author

Sounds great, thank you!

I hope I can start contributing some code changes to the repo soon. I've been so busy at work trying to make the TimePicker we're building off of yours, so I've been able to QA it, but not make active code constructions.

@wojtekmaj
Copy link
Owner

Confirmed on Edge 18.
It looks like Edge can't keep selection on re-render, and re-render (showing clock) happens after text selection.

@wojtekmaj
Copy link
Owner

Just a heads-up - React-Time-Picker v3.6.0 was released a few moments ago and includes the fix for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants