Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent behavior between 12 hour and 24 hour TimePicker, when you clear minutes #329

Closed
McSam27 opened this issue Nov 20, 2023 · 2 comments
Labels

Comments

@McSam27
Copy link

McSam27 commented Nov 20, 2023

Description:
I'm noticing some inconsistent behavior between 12hr and 24hr locales with the TimePicker.
In the video, I'm showcasing the fr locale (24hr) and en locale (12hr) as examples. When clearing the minutes of the 24hr TimePicker, it also clears the hours. But, when clearing the 12hr TimePicker, it does not clear the hours and it also keeps the original entry.

I would expect the behavior to be the same, no matter what clock version, 24hr and 12hr should have the same behavior.

Version Effected: (latest)6.5.2 -- (I noticed this on v5.0.0 as well)

Example/Repro code:

<ReactTimePicker
    disableClock
    onChange={(time) => this.onChange('FR', time)}
    value={this.state.timeFR}
    locale="fr" // 24hr
/>
<ReactTimePicker
    disableClock
    onChange={(time) => this.onChange('US', time)}
    value={this.state.timeUS}
    locale="en" // 12hr
/>

Video: (using keyboard nav to tab)
ezgif com-optimize

Copy link
Contributor

github-actions bot commented Mar 4, 2024

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this issue will be closed in 14 days.

@github-actions github-actions bot added the stale label Mar 4, 2024
Copy link
Contributor

This issue was closed because it has been stalled for 14 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant