Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent render functions from being invoked more than once resulting in multiple inputs for the same thing #44

Merged
merged 2 commits into from
Jul 11, 2019
Merged

Prevent render functions from being invoked more than once resulting in multiple inputs for the same thing #44

merged 2 commits into from
Jul 11, 2019

Conversation

wojtekmaj
Copy link
Owner

@wojtekmaj wojtekmaj commented Jul 11, 2019 •
edited
Loading

Closes #30

Prevents render functions from being invoked more than once in non-custom formats, which will never happen on purpose. You can still create a format like H h which will display both 24- and 12-hour inputs.

@wojtekmaj wojtekmaj added the bug Something isn't working label Jul 11, 2019
@wojtekmaj
Prevent render functions from being invoked more than once resulting …
adf8caa 
…in multiple inputs for the same thing

Could help with #30, but at the cost of less flexibility - no possibility for multiple inputs
@wojtekmaj wojtekmaj merged commit bd13def into master Jul 11, 2019
@wojtekmaj wojtekmaj deleted the no-input-repeat branch July 11, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

French Canadian (locale="fr-CA") shows both 24 and 12 hour inputs
1 participant
@wojtekmaj