Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aria-label to inputs #21

Closed
nickbristow opened this issue May 16, 2019 · 3 comments
Closed

Add aria-label to inputs #21

nickbristow opened this issue May 16, 2019 · 3 comments
Assignees
@wojtekmaj
Labels
enhancement New feature or request

Comments

@nickbristow
Copy link
Contributor

For accessibility reasons, each of the inputs generated should have a label.

Adding aria-label='hour'to the hour input, and one for minute, and PM/AM should be on by default, or give us the option to enable them.
@nickbristow nickbristow mentioned this issue May 16, 2019
Closed
@wojtekmaj wojtekmaj added the enhancement New feature or request label May 23, 2019
@wojtekmaj wojtekmaj self-assigned this May 23, 2019
@wojtekmaj
Copy link
Owner

Will introduce:

  • hourAriaLabel
  • minuteAriaLabel
  • secondAriaLabel
  • amPmAriaLabel

@wojtekmaj wojtekmaj mentioned this issue May 23, 2019
Closed
@emilyuhde
Copy link
Contributor

The x to clear icon button and the clock icon button should both have props to add an aria-label as well. Anything clickable needs an aria-label.

@wojtekmaj
Copy link
Owner

Closed via 318845a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wojtekmaj wojtekmaj

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@emilyuhde @nickbristow @wojtekmaj