Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for id prop #18

Closed
reverie opened this issue Apr 10, 2019 · 4 comments
Closed

Add support for id prop #18

reverie opened this issue Apr 10, 2019 · 4 comments
Labels
enhancement New feature or request stale

Comments

@reverie
Copy link

reverie commented Apr 10, 2019

Setup:
I have a <label for="x"> and <TimePicker id="x">

Expected behavior:
Clicking the label opens the time picker

Actual behavior:
Nothing happens

@wojtekmaj wojtekmaj added the enhancement New feature or request label Apr 11, 2019
@github-actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this issue will be closed in 14 days.

@github-actions github-actions bot added the stale label Sep 27, 2021
@wojtekmaj
Copy link
Owner

wojtekmaj commented Sep 27, 2021

Here's the thing: React-Time-Picker creates a set of inputs, so it's not possible to use id like described at all. Best we can do is attach id to the wrapper containing all the inputs, like we do with className.

@wojtekmaj wojtekmaj removed the stale label Sep 27, 2021
@github-actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this issue will be closed in 14 days.

@github-actions github-actions bot added the stale label Dec 27, 2021
@github-actions
Copy link
Contributor

This issue was closed because it has been stalled for 14 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

2 participants