Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AM/PM selector is visible on a locale which is 24 hour (bg-BG) #14

Closed
phtmgt opened this issue Jan 21, 2019 · 4 comments
Closed

AM/PM selector is visible on a locale which is 24 hour (bg-BG) #14

phtmgt opened this issue Jan 21, 2019 · 4 comments
Assignees
@wojtekmaj
Labels
bug Something isn't working

Comments

@phtmgt
Copy link

phtmgt commented Jan 21, 2019

Clock is ok and it is in 24 hour format. But we still get the AM/PM picker which, instead of 'AM' and 'PM' options shows a strange single '21 ч.' select option. 'ч.' is short for 'hours' in bg-BG.

Bug maybe?
@phtmgt phtmgt changed the title AM/PM selector on a locale which is 24 hour (bg-BG) AM/PM selector is visible on a locale which is 24 hour (bg-BG) Jan 21, 2019
@wojtekmaj
Copy link
Owner

What version are you on?

@phtmgt
Copy link
Author

phtmgt commented Jan 21, 2019 •
edited
Loading

[email protected], freshly added today.

This is what gets rendered:

<select class="react-datetime-picker__inputGroup__input react-datetime-picker__inputGroup__amPm" name="amPm"><option value="">--</option><option value="am"></option><option value="pm">21 ч.</option></select>

@wojtekmaj
Copy link
Owner

Thanks so much. Moving this issue to react-time-picker which is used to get AM/PM selector. The issue is clearly in getAmPmLabels function there.

@wojtekmaj wojtekmaj transferred this issue from wojtekmaj/react-datetime-picker Jan 28, 2019
@wojtekmaj
Copy link
Owner

Fixed in v3.6.0 (I think - can't pinpoint the exact fix right now, possibly fixed with #25).

@wojtekmaj wojtekmaj self-assigned this Jul 24, 2019
@wojtekmaj wojtekmaj added the bug Something isn't working label Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wojtekmaj wojtekmaj

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wojtekmaj @phtmgt