Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeInput should take (and use) a ref prop #108

Closed
billsaysthis opened this issue Feb 19, 2021 · 4 comments
Closed

TimeInput should take (and use) a ref prop #108

billsaysthis opened this issue Feb 19, 2021 · 4 comments
Labels
question Further information is requested stale

Comments

@billsaysthis
Copy link

This is needed for use with common validation libs, e.g., Yup with React-Hook-Form. (Happy to provide additional info but not sure what that might be, this seems pretty self-explanatory...)

@wojtekmaj
Copy link
Owner

Every React component takes ref prop. I suppose you mean that ref prop should point to something else than TimeInput component itself?

This would be a breaking change for sure to begin with.

What, in your opinion, ref should be pointing to? Main div? Native hidden input[type="time"]?

@wojtekmaj wojtekmaj added the question Further information is requested label Mar 22, 2021
@billsaysthis
Copy link
Author

This might be an issue more with the types for RTP (which I know you don't work on or approve), but in our case the ref needs to point to whatever has the current time value as it would be used for react-hook-form validators.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this issue will be closed in 14 days.

@github-actions github-actions bot added the stale label Aug 26, 2021
@github-actions
Copy link
Contributor

This issue was closed because it has been stalled for 14 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested stale
Projects
None yet
Development

No branches or pull requests

2 participants