Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support For 12 Hour AM/PM format? #1

Closed
forrestbice opened this issue Mar 5, 2018 · 12 comments
Closed

Support For 12 Hour AM/PM format? #1

forrestbice opened this issue Mar 5, 2018 · 12 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@forrestbice
Copy link

Is there a way to configure the library to use 12 hour format rather than 24 hour format?

@wojtekmaj
Copy link
Owner

Not at the moment, but that's planned for development and the way is paved for this function to be implemented.

@wojtekmaj wojtekmaj self-assigned this Mar 5, 2018
@wojtekmaj wojtekmaj added the enhancement New feature or request label Mar 5, 2018
@forrestbice
Copy link
Author

@wojtekmaj awesome! Is there an ETA for this?

@wojtekmaj
Copy link
Owner

I didn't set it, but now that I see demand I'll try to prioritize.

@forrestbice
Copy link
Author

Sweet, we'd greatly appreciate it, this library is great!

@forrestbice
Copy link
Author

@wojtekmaj any updates on this by chance?

@wojtekmaj
Copy link
Owner

wojtekmaj commented Mar 18, 2018

Hi @forrestbice,
it's in the works :) Firstly it will be introduced in React-Time-Picker, on which React-DateTime-Picker depends. You can track progress in wojtekmaj/react-time-picker#3. It's working so far, but I need to add extensive testing though.

@forrestbice
Copy link
Author

Awesome @wojtekmaj! I just subscribed to the issue and associated PR in React-Time-Picker. Really looking forward to this merging and making its way to React-DateTime-Picker 🤘

@wojtekmaj
Copy link
Owner

Hope you'll still have some patience :) I am doing this only during my free time apart from being employed full time! 😱

@wojtekmaj
Copy link
Owner

Added in v1.4.0.

@wojtekmaj wojtekmaj added this to the 1.4.0 milestone Jul 16, 2018
@forrestbice
Copy link
Author

Awesome @wojtekmaj, thanks!

@shahar4
Copy link

shahar4 commented Aug 19, 2018

Hey!

That's awesome that you allow this feature! How can I enable it?

Thanks!

@wojtekmaj
Copy link
Owner

wojtekmaj commented Aug 20, 2018

@shahar4 It's enabled automatically for locales which use 12 hour clock. Just pass locale prop with a locale which uses 12-hour clock, like en-US.

The reason why locale is used is that locale in fact is so much more than just that. It's also date format, date separators, calendar (Arabic, US, Hebrew, ISO...), workdays, week starting day....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants