feat: 🎊 Any length of invitation code #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No reason at all that I can see, was before my time. I'll take a look at this PR once I have the time as i'm currently working. Thanks for another PR btw, you're smashing it. If you're in the Discord let me know, and i'll give you the Developer role so you can chat amongst the team 😀. |
wizarr-sentry bot
pushed a commit
that referenced
this pull request
Aug 2, 2024
## [4.2.0-beta.2](v4.2.0-beta.1...v4.2.0-beta.2) (2024-08-02) ### New Features * 🎊 Any length of invitation code ([#469](#469)) ([c850c8e](c850c8e)) ### Bug Fixes * 🐛 Solve issue reordering onboarding pages ([2f6ca87](2f6ca87)) * 🐛 Solve some issues with markdown preview ([#470](#470)) ([2051990](2051990))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if there was a reason to have a fixed length for invitation codes?
The reason for me implementing this feature is to have an invitation code for users to use for trying my Plex instance. (A code that can be used unlimited number of times with a user duration of 1 week). For this I don't want a random string as the invitation code (I could't come up with something with exactly 6 characters).
I will later try to implement a new validation feature for invitation codes, that can accept unlimited usages but one one per user.