-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minify
option is deprecated
#58
Comments
You can toggle of the option explicitly: const { html, errors } = render(email, {
minify: false
}); Since this option is deprecated, I agree that the default should be false. |
I resolved using the same dependency ( minify(html, {
collapseWhitespace: true,
minifyCSS: false,
caseSensitive: true,
removeEmptyAttributes: true,
}) The minify option is really useful and I hope it helps, one good thing is to move this handling into |
PRs are welcome |
Yes, it does not work locally anymore. |
Shall this be fixed? |
It is complicated. We would need to drop |
I know its complicated, but maybe worth it, if this package is not public? |
It was public and is not public anymore. Most probably we will do something about it but we have other pressing problems to solve now and time will come to this problem as well eventually. |
The
minify
option is depreciated and when used a warning is triggered(see image). To solve it we could just remove the minify, what do you think?PR that removed the minify option: mjmlio/mjml#2059
The text was updated successfully, but these errors were encountered: