Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for mj-html-attributes, mj-selector, mj-html-attribute? #71

Closed
philipwindeyer opened this issue Feb 18, 2022 · 6 comments · Fixed by #72
Closed

Support for mj-html-attributes, mj-selector, mj-html-attribute? #71

philipwindeyer opened this issue Feb 18, 2022 · 6 comments · Fixed by #72

Comments

@philipwindeyer
Copy link
Contributor

Hello, is there a timeline on adding support for the newer mj-html-attributes, mj-selector, and mj-html-attribute head components?

I.e. https://documentation.mjml.io/#mj-html-attributes

Thanks in advance
@daliusd
Copy link
Contributor

daliusd commented Feb 18, 2022

There is pull request #54 but it is conflicting with master. Wanna fix it?

@philipwindeyer
Copy link
Contributor Author

Saw that; although it's a year old and it's attempting to redefine MjmlAttributes as MjmlHtmlAttribute 😕.

I can dedicate time to this on Monday. Will open a new PR then if that works for you? @daliusd

@daliusd
Copy link
Contributor

daliusd commented Feb 18, 2022

Yes, it works for me.

@philipwindeyer philipwindeyer mentioned this issue Feb 23, 2022
Merged
@philipwindeyer
Copy link
Contributor Author

Hey @daliusd, just opened #72 . Will update types in DefinitelyTyped shortly

@daliusd
Copy link
Contributor

daliusd commented Feb 23, 2022

Hi @philipwindeyer we will review it.

@philipwindeyer
Copy link
Contributor Author

FYI: PR for accompanying typedefs, for the TypeScripters DefinitelyTyped/DefinitelyTyped#59026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add mjml-attributes, mjml-selector and mjml-html-attribute philipwindeyer/mjml-react
2 participants
@daliusd @philipwindeyer