Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sitemap for repo with 2 domains should offer an optional function to apply to the strings. #944

Closed
disrae opened this issue Jun 6, 2024 Discussed in #941 · 1 comment

Comments

@disrae
Copy link

disrae commented Jun 6, 2024

Discussed in #941

Originally posted by disrae June 4, 2024

Summary

The Astro config does not have access to the slug, so the sitemap generator can only access one domain, there is no data to make the domain dynamic with.
For repos with two domains it would be nice pass a function to the generator which is applied to the url strings as they are generated.

Background & Motivation

For repos that implement two or more domains based on locale (my case), I need to be able to generate a sitemap that has the correct domain for each slug. For every slug that has '/en-us' in the string I want to switch out the domain.

Goals

A lightweight, non-breaking change to give more custom control in the sitemap generation process.

Example

I would simply want to add it in the options object for the sitemap generator.

@Princesseuh
Copy link
Member

Please don't create issues yourself, we'll move discussions to stage 2 once they're ready.

@Princesseuh Princesseuh closed this as not planned Won't fix, can't repro, duplicate, stale Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants