From dc926299ccd3fd1fec092935881bc452f8f0dd34 Mon Sep 17 00:00:00 2001 From: Matthew Phillips Date: Tue, 23 Mar 2021 08:52:02 -0400 Subject: [PATCH 1/2] Add support for React components. This adds support for react components via a new `extensions` config in astro.config.mjs. In the future we can extend this to do things like look at the import statements, as Snowpack does. --- examples/snowpack/astro.config.mjs | 5 +- examples/snowpack/package-lock.json | 38 ++++++++++++ examples/snowpack/package.json | 1 + package-lock.json | 60 +++++++++++++++++-- package.json | 4 +- snowpack-plugin.cjs | 8 ++- src/@types/astro.ts | 4 ++ src/@types/compiler.ts | 2 + src/codegen/index.ts | 50 ++++++++++++++-- src/frontend/render/react.ts | 28 +++++++++ src/runtime.ts | 12 +++- .../fixtures/react-component/astro.config.mjs | 7 +++ .../astro/components/Hello.jsx | 5 ++ .../react-component/astro/pages/index.hmx | 10 ++++ .../react-component/snowpack.config.js | 5 ++ test/react-component.test.js | 35 +++++++++++ test/snowpack-integration.test.js | 7 +-- 17 files changed, 258 insertions(+), 23 deletions(-) create mode 100644 src/frontend/render/react.ts create mode 100644 test/fixtures/react-component/astro.config.mjs create mode 100644 test/fixtures/react-component/astro/components/Hello.jsx create mode 100644 test/fixtures/react-component/astro/pages/index.hmx create mode 100644 test/fixtures/react-component/snowpack.config.js create mode 100644 test/react-component.test.js diff --git a/examples/snowpack/astro.config.mjs b/examples/snowpack/astro.config.mjs index dbe6dc0ac332..0f0be4b943de 100644 --- a/examples/snowpack/astro.config.mjs +++ b/examples/snowpack/astro.config.mjs @@ -2,5 +2,8 @@ export default { projectRoot: '.', hmxRoot: './astro', - dist: './_site' + dist: './_site', + extensions: { + '.jsx': 'preact' + } } \ No newline at end of file diff --git a/examples/snowpack/package-lock.json b/examples/snowpack/package-lock.json index d5d9e09a9ce8..d4575f17a9a2 100644 --- a/examples/snowpack/package-lock.json +++ b/examples/snowpack/package-lock.json @@ -1269,6 +1269,8 @@ "requires": { "@types/estree": "0.0.46", "@types/node": "^14.14.31", + "@types/react": "^17.0.3", + "@types/react-dom": "^17.0.2", "@vue/server-renderer": "^3.0.7", "acorn": "^7.4.0", "acorn-jsx": "^5.3.1", @@ -1292,6 +1294,7 @@ "react": "^17.0.1", "react-dom": "^17.0.1", "sass": "^1.32.8", + "snowpack": "^3.1.0-pre.13", "svelte": "^3.35.0", "vue": "^3.0.7", "yargs-parser": "^20.2.7" @@ -1463,6 +1466,36 @@ "resolved": "https://registry.npmjs.org/@types/normalize-package-data/-/normalize-package-data-2.4.0.tgz", "integrity": "sha512-f5j5b/Gf71L+dbqxIpQ4Z2WlmI/mPJ0fOkGGmFgtb6sAu97EPczzbS3/tJKxmcYDj55OX6ssqwDAWOHIYDRDGA==" }, + "@types/prop-types": { + "version": "15.7.3", + "resolved": "https://registry.npmjs.org/@types/prop-types/-/prop-types-15.7.3.tgz", + "integrity": "sha512-KfRL3PuHmqQLOG+2tGpRO26Ctg+Cq1E01D2DMriKEATHgWLfeNDmq9e29Q9WIky0dQ3NPkd1mzYH8Lm936Z9qw==" + }, + "@types/react": { + "version": "17.0.3", + "resolved": "https://registry.npmjs.org/@types/react/-/react-17.0.3.tgz", + "integrity": "sha512-wYOUxIgs2HZZ0ACNiIayItyluADNbONl7kt8lkLjVK8IitMH5QMyAh75Fwhmo37r1m7L2JaFj03sIfxBVDvRAg==", + "requires": { + "@types/prop-types": "*", + "@types/scheduler": "*", + "csstype": "^3.0.2" + }, + "dependencies": { + "csstype": { + "version": "3.0.7", + "resolved": "https://registry.npmjs.org/csstype/-/csstype-3.0.7.tgz", + "integrity": "sha512-KxnUB0ZMlnUWCsx2Z8MUsr6qV6ja1w9ArPErJaJaF8a5SOWoHLIszeCTKGRGRgtLgYrs1E8CHkNSP1VZTTPc9g==" + } + } + }, + "@types/react-dom": { + "version": "17.0.2", + "resolved": "https://registry.npmjs.org/@types/react-dom/-/react-dom-17.0.2.tgz", + "integrity": "sha512-Icd9KEgdnFfJs39KyRyr0jQ7EKhq8U6CcHRMGAS45fp5qgUvxL3ujUCfWFttUK2UErqZNj97t9gsVPNAqcwoCg==", + "requires": { + "@types/react": "*" + } + }, "@types/sass": { "version": "1.16.0", "resolved": "https://registry.npmjs.org/@types/sass/-/sass-1.16.0.tgz", @@ -1471,6 +1504,11 @@ "@types/node": "*" } }, + "@types/scheduler": { + "version": "0.16.1", + "resolved": "https://registry.npmjs.org/@types/scheduler/-/scheduler-0.16.1.tgz", + "integrity": "sha512-EaCxbanVeyxDRTQBkdLb3Bvl/HK7PBK6UJjsSixB0iHKoWxE5uu2Q/DgtpOhPIojN0Zl1whvOd7PoHs2P0s5eA==" + }, "@types/yargs-parser": { "version": "20.2.0", "resolved": "https://registry.npmjs.org/@types/yargs-parser/-/yargs-parser-20.2.0.tgz", diff --git a/examples/snowpack/package.json b/examples/snowpack/package.json index a7b82b176dda..df38fe6e7d6e 100644 --- a/examples/snowpack/package.json +++ b/examples/snowpack/package.json @@ -44,6 +44,7 @@ "postcss-preset-env": "^6.7.0", "prettier": "^2.0.5", "snowpack": "^3.1.0-pre.14", + "sass": "^1.32.8", "stylelint": "^13.8.0", "stylelint-config-prettier": "^8.0.2", "stylelint-config-rational-order": "^0.1.2", diff --git a/package-lock.json b/package-lock.json index 4b5e338bcb74..7381f6d2f774 100644 --- a/package-lock.json +++ b/package-lock.json @@ -190,6 +190,36 @@ "integrity": "sha512-f5j5b/Gf71L+dbqxIpQ4Z2WlmI/mPJ0fOkGGmFgtb6sAu97EPczzbS3/tJKxmcYDj55OX6ssqwDAWOHIYDRDGA==", "dev": true }, + "@types/prop-types": { + "version": "15.7.3", + "resolved": "https://registry.npmjs.org/@types/prop-types/-/prop-types-15.7.3.tgz", + "integrity": "sha512-KfRL3PuHmqQLOG+2tGpRO26Ctg+Cq1E01D2DMriKEATHgWLfeNDmq9e29Q9WIky0dQ3NPkd1mzYH8Lm936Z9qw==" + }, + "@types/react": { + "version": "17.0.3", + "resolved": "https://registry.npmjs.org/@types/react/-/react-17.0.3.tgz", + "integrity": "sha512-wYOUxIgs2HZZ0ACNiIayItyluADNbONl7kt8lkLjVK8IitMH5QMyAh75Fwhmo37r1m7L2JaFj03sIfxBVDvRAg==", + "requires": { + "@types/prop-types": "*", + "@types/scheduler": "*", + "csstype": "^3.0.2" + }, + "dependencies": { + "csstype": { + "version": "3.0.7", + "resolved": "https://registry.npmjs.org/csstype/-/csstype-3.0.7.tgz", + "integrity": "sha512-KxnUB0ZMlnUWCsx2Z8MUsr6qV6ja1w9ArPErJaJaF8a5SOWoHLIszeCTKGRGRgtLgYrs1E8CHkNSP1VZTTPc9g==" + } + } + }, + "@types/react-dom": { + "version": "17.0.2", + "resolved": "https://registry.npmjs.org/@types/react-dom/-/react-dom-17.0.2.tgz", + "integrity": "sha512-Icd9KEgdnFfJs39KyRyr0jQ7EKhq8U6CcHRMGAS45fp5qgUvxL3ujUCfWFttUK2UErqZNj97t9gsVPNAqcwoCg==", + "requires": { + "@types/react": "*" + } + }, "@types/sass": { "version": "1.16.0", "resolved": "https://registry.npmjs.org/@types/sass/-/sass-1.16.0.tgz", @@ -199,6 +229,11 @@ "@types/node": "*" } }, + "@types/scheduler": { + "version": "0.16.1", + "resolved": "https://registry.npmjs.org/@types/scheduler/-/scheduler-0.16.1.tgz", + "integrity": "sha512-EaCxbanVeyxDRTQBkdLb3Bvl/HK7PBK6UJjsSixB0iHKoWxE5uu2Q/DgtpOhPIojN0Zl1whvOd7PoHs2P0s5eA==" + }, "@types/yargs-parser": { "version": "20.2.0", "resolved": "https://registry.npmjs.org/@types/yargs-parser/-/yargs-parser-20.2.0.tgz", @@ -475,6 +510,7 @@ "version": "3.1.1", "resolved": "https://registry.npmjs.org/anymatch/-/anymatch-3.1.1.tgz", "integrity": "sha512-mM8522psRCqzV+6LhomX5wgp25YVibjh8Wj23I5RPkPppSVSjyKD2A2mBJmWGa+KN7f2D6LNh9jkBCeyLktzjg==", + "dev": true, "requires": { "normalize-path": "^3.0.0", "picomatch": "^2.0.4" @@ -538,7 +574,8 @@ "binary-extensions": { "version": "2.2.0", "resolved": "https://registry.npmjs.org/binary-extensions/-/binary-extensions-2.2.0.tgz", - "integrity": "sha512-jDctJ/IVQbZoJykoeHbhXpOlNBqGNcwXJKJog42E5HDPUwQTSdjCHdihjj0DlnheQ7blbT6dHOafNAiS8ooQKA==" + "integrity": "sha512-jDctJ/IVQbZoJykoeHbhXpOlNBqGNcwXJKJog42E5HDPUwQTSdjCHdihjj0DlnheQ7blbT6dHOafNAiS8ooQKA==", + "dev": true }, "boolbase": { "version": "1.0.0", @@ -585,6 +622,7 @@ "version": "3.0.2", "resolved": "https://registry.npmjs.org/braces/-/braces-3.0.2.tgz", "integrity": "sha512-b8um+L1RzM3WDSzvhm6gIz1yfTbBt6YTlcEKAvsmqCZZFw46z626lVj9j1yEPW33H5H+lBQpZMP1k8l+78Ha0A==", + "dev": true, "requires": { "fill-range": "^7.0.1" } @@ -724,6 +762,7 @@ "version": "3.5.1", "resolved": "https://registry.npmjs.org/chokidar/-/chokidar-3.5.1.tgz", "integrity": "sha512-9+s+Od+W0VJJzawDma/gvBNQqkTiqYTWLuZoyAsivsI4AaWTCzHG06/TMjsf1cYe9Cb97UCEhjz7HvnPk2p/tw==", + "dev": true, "requires": { "anymatch": "~3.1.1", "braces": "~3.0.2", @@ -1509,6 +1548,7 @@ "version": "7.0.1", "resolved": "https://registry.npmjs.org/fill-range/-/fill-range-7.0.1.tgz", "integrity": "sha512-qOo9F+dMUmC2Lcb4BbVvnKJxTPjCm+RRpe4gDuGrzkL7mEVl/djYSu2OdQ2Pa302N4oqkSg9ir6jaLWJ2USVpQ==", + "dev": true, "requires": { "to-regex-range": "^5.0.1" } @@ -1614,6 +1654,7 @@ "version": "5.1.2", "resolved": "https://registry.npmjs.org/glob-parent/-/glob-parent-5.1.2.tgz", "integrity": "sha512-AOIgSQCepiJYwP3ARnGx+5VnTu2HBYdzbGP45eLw1vr3zB3vZLeyed1sC9hnbcOc9/SrMyM5RPQrkGz4aS9Zow==", + "dev": true, "requires": { "is-glob": "^4.0.1" } @@ -1865,6 +1906,7 @@ "version": "2.1.0", "resolved": "https://registry.npmjs.org/is-binary-path/-/is-binary-path-2.1.0.tgz", "integrity": "sha512-ZMERYes6pDydyuGidse7OsHxtbI7WVeUEozgR/g7rd0xUimYNlvZRE/K2MgZTjWy725IfelLeVcEM97mmtRGXw==", + "dev": true, "requires": { "binary-extensions": "^2.0.0" } @@ -1906,7 +1948,8 @@ "is-extglob": { "version": "2.1.1", "resolved": "https://registry.npmjs.org/is-extglob/-/is-extglob-2.1.1.tgz", - "integrity": "sha1-qIwCU1eR8C7TfHahueqXc8gz+MI=" + "integrity": "sha1-qIwCU1eR8C7TfHahueqXc8gz+MI=", + "dev": true }, "is-fullwidth-code-point": { "version": "3.0.0", @@ -1918,6 +1961,7 @@ "version": "4.0.1", "resolved": "https://registry.npmjs.org/is-glob/-/is-glob-4.0.1.tgz", "integrity": "sha512-5G0tKtBTFImOqDnLB2hG6Bp2qcKEFduo4tZu9MT/H6NQv/ghhy30o55ufafxJ/LdH79LLs2Kfrn85TLKyA7BUg==", + "dev": true, "requires": { "is-extglob": "^2.1.1" } @@ -1946,7 +1990,8 @@ "is-number": { "version": "7.0.0", "resolved": "https://registry.npmjs.org/is-number/-/is-number-7.0.0.tgz", - "integrity": "sha512-41Cifkg6e8TylSpdtTpeLVMqvSBEVzTttHvERD741+pnZ8ANv0004MRL43QKPDlK9cGvNp6NZWZUBlbGXYxxng==" + "integrity": "sha512-41Cifkg6e8TylSpdtTpeLVMqvSBEVzTttHvERD741+pnZ8ANv0004MRL43QKPDlK9cGvNp6NZWZUBlbGXYxxng==", + "dev": true }, "is-obj": { "version": "2.0.0", @@ -2357,7 +2402,8 @@ "normalize-path": { "version": "3.0.0", "resolved": "https://registry.npmjs.org/normalize-path/-/normalize-path-3.0.0.tgz", - "integrity": "sha512-6eZs5Ls3WtCisHWp9S2GUy8dqkpGi4BVSz3GaqiE6ezub0512ESztXUwUB6C6IKbQkY2Pnb/mD4WYojCRwcwLA==" + "integrity": "sha512-6eZs5Ls3WtCisHWp9S2GUy8dqkpGi4BVSz3GaqiE6ezub0512ESztXUwUB6C6IKbQkY2Pnb/mD4WYojCRwcwLA==", + "dev": true }, "normalize-range": { "version": "0.1.2", @@ -2525,7 +2571,8 @@ "picomatch": { "version": "2.2.2", "resolved": "https://registry.npmjs.org/picomatch/-/picomatch-2.2.2.tgz", - "integrity": "sha512-q0M/9eZHzmr0AulXyPwNfZjtwZ/RBZlbN3K3CErVrk50T2ASYI7Bye0EvekFY3IP1Nt2DHu0re+V2ZHIpMkuWg==" + "integrity": "sha512-q0M/9eZHzmr0AulXyPwNfZjtwZ/RBZlbN3K3CErVrk50T2ASYI7Bye0EvekFY3IP1Nt2DHu0re+V2ZHIpMkuWg==", + "dev": true }, "pify": { "version": "2.3.0", @@ -2769,6 +2816,7 @@ "version": "3.5.0", "resolved": "https://registry.npmjs.org/readdirp/-/readdirp-3.5.0.tgz", "integrity": "sha512-cMhu7c/8rdhkHXWsY+osBhfSy0JikwpHK/5+imo+LpeasTF8ouErHrlYkwT0++njiyuDvc7OFY5T3ukvZ8qmFQ==", + "dev": true, "requires": { "picomatch": "^2.2.1" } @@ -2889,6 +2937,7 @@ "version": "1.32.8", "resolved": "https://registry.npmjs.org/sass/-/sass-1.32.8.tgz", "integrity": "sha512-Sl6mIeGpzjIUZqvKnKETfMf0iDAswD9TNlv13A7aAF3XZlRPMq4VvJWBC2N2DXbp94MQVdNSFG6LfF/iOXrPHQ==", + "dev": true, "requires": { "chokidar": ">=2.0.0 <4.0.0" } @@ -3222,6 +3271,7 @@ "version": "5.0.1", "resolved": "https://registry.npmjs.org/to-regex-range/-/to-regex-range-5.0.1.tgz", "integrity": "sha512-65P7iz6X5yEr1cwcgvQxbbIw7Uk3gOy5dIdtZ4rDveLqhrdJP+Li/Hx6tyK0NEb+2GCyneCMJiGqrADCSNk8sQ==", + "dev": true, "requires": { "is-number": "^7.0.0" } diff --git a/package.json b/package.json index 7d65fb6ecd5b..dbdd9d596ba7 100644 --- a/package.json +++ b/package.json @@ -27,6 +27,8 @@ "dependencies": { "@types/estree": "0.0.46", "@types/node": "^14.14.31", + "@types/react": "^17.0.3", + "@types/react-dom": "^17.0.2", "@vue/server-renderer": "^3.0.7", "acorn": "^7.4.0", "acorn-jsx": "^5.3.1", @@ -50,6 +52,7 @@ "react": "^17.0.1", "react-dom": "^17.0.1", "sass": "^1.32.8", + "snowpack": "^3.1.0-pre.14", "svelte": "^3.35.0", "vue": "^3.0.7", "yargs-parser": "^20.2.7" @@ -72,7 +75,6 @@ "preact": "^10.5.12", "preact-render-to-string": "^5.1.14", "prettier": "^2.2.1", - "snowpack": "^3.1.0-pre.14", "typescript": "^4.2.3", "uvu": "^0.5.1" } diff --git a/snowpack-plugin.cjs b/snowpack-plugin.cjs index 969b6075eb59..b4ea1b9aff49 100644 --- a/snowpack-plugin.cjs +++ b/snowpack-plugin.cjs @@ -3,7 +3,7 @@ const { readFile } = require('fs').promises; // Snowpack plugins must be CommonJS :( const transformPromise = import('./lib/transform2.js'); -module.exports = function (snowpackConfig, { resolve } = {}) { +module.exports = function (snowpackConfig, { resolve, extensions } = {}) { return { name: 'snowpack-hmx', knownEntrypoints: ['deepmerge'], @@ -15,7 +15,11 @@ module.exports = function (snowpackConfig, { resolve } = {}) { const { compileComponent } = await transformPromise; const projectRoot = snowpackConfig.root; const contents = await readFile(filePath, 'utf-8'); - const result = await compileComponent(contents, { compileOptions: { resolve }, filename: filePath, projectRoot }); + const compileOptions = { + resolve, + extensions + }; + const result = await compileComponent(contents, { compileOptions, filename: filePath, projectRoot }); return result.contents; }, }; diff --git a/src/@types/astro.ts b/src/@types/astro.ts index 69994375c733..8d5979eece3f 100644 --- a/src/@types/astro.ts +++ b/src/@types/astro.ts @@ -2,12 +2,16 @@ export interface AstroConfigRaw { dist: string; projectRoot: string; hmxRoot: string; + jsx?: string; } +export type ValidExtensionPlugins = 'hmx' | 'react' | 'preact' | 'svelte' | 'vue'; + export interface AstroConfig { dist: string; projectRoot: URL; hmxRoot: URL; + extensions?: Record } export interface JsxItem { diff --git a/src/@types/compiler.ts b/src/@types/compiler.ts index 4569242671ad..4e0ee6250a6f 100644 --- a/src/@types/compiler.ts +++ b/src/@types/compiler.ts @@ -1,6 +1,8 @@ import type { LogOptions } from '../logger'; +import type { ValidExtensionPlugins } from './astro'; export interface CompileOptions { logging: LogOptions; resolve: (p: string) => string; + extensions?: Record; } diff --git a/src/codegen/index.ts b/src/codegen/index.ts index 725546f51f59..a9fc433f47d4 100644 --- a/src/codegen/index.ts +++ b/src/codegen/index.ts @@ -1,4 +1,5 @@ import type { CompileOptions } from '../@types/compiler'; +import type { ValidExtensionPlugins } from '../@types/astro'; import type { Ast, TemplateNode } from '../compiler/interfaces'; import type { JsxItem, TransformResult } from '../@types/astro'; @@ -89,10 +90,34 @@ function generateAttributes(attrs: Record): string { return result + '}'; } -function getComponentWrapper(_name: string, { type, url }: { type: string; url: string }, { resolve }: CompileOptions) { +interface ComponentInfo { + type: string; + url: string; +} + +const defaultExtensions: Readonly> = { + '.hmx': 'hmx', + '.jsx': 'react', + '.vue': 'vue', + '.svelte': 'svelte' +}; + +function getComponentWrapper(_name: string, { type, url }: ComponentInfo, compileOptions: CompileOptions) { + const { + resolve, + extensions = defaultExtensions + } = compileOptions; + const [name, kind] = _name.split(':'); - switch (type) { - case '.hmx': { + + const plugin = extensions[type] || defaultExtensions[type]; + + if(!plugin) { + throw new Error(`No supported plugin found for extension ${type}`); + } + + switch (plugin) { + case 'hmx': { if (kind) { throw new Error(`HMX does not support :${kind}`); } @@ -101,7 +126,7 @@ function getComponentWrapper(_name: string, { type, url }: { type: string; url: wrapperImport: ``, }; } - case '.jsx': { + case 'preact': { if (kind === 'dynamic') { return { wrapper: `__preact_dynamic(${name}, new URL(${JSON.stringify(url.replace(/\.[^.]+$/, '.js'))}, \`http://TEST\${import.meta.url}\`).pathname, '${resolve('preact')}')`, @@ -114,7 +139,20 @@ function getComponentWrapper(_name: string, { type, url }: { type: string; url: }; } } - case '.svelte': { + case 'react': { + if (kind === 'dynamic') { + return { + wrapper: `__react_dynamic(${name}, new URL(${JSON.stringify(url.replace(/\.[^.]+$/, '.js'))}, \`http://TEST\${import.meta.url}\`).pathname, '${resolve('react')}', '${resolve('react-dom')}')`, + wrapperImport: `import {__react_dynamic} from '${internalImport('render/react.js')}';`, + }; + } else { + return { + wrapper: `__react_static(${name})`, + wrapperImport: `import {__react_static} from '${internalImport('render/react.js')}';`, + }; + } + } + case 'svelte': { if (kind === 'dynamic') { return { wrapper: `__svelte_dynamic(${name}, new URL(${JSON.stringify(url.replace(/\.[^.]+$/, '.svelte.js'))}, \`http://TEST\${import.meta.url}\`).pathname)`, @@ -127,7 +165,7 @@ function getComponentWrapper(_name: string, { type, url }: { type: string; url: }; } } - case '.vue': { + case 'vue': { if (kind === 'dynamic') { return { wrapper: `__vue_dynamic(${name}, new URL(${JSON.stringify(url.replace(/\.[^.]+$/, '.vue.js'))}, \`http://TEST\${import.meta.url}\`).pathname, '${resolve('vue')}')`, diff --git a/src/frontend/render/react.ts b/src/frontend/render/react.ts new file mode 100644 index 000000000000..d55d30c00b1c --- /dev/null +++ b/src/frontend/render/react.ts @@ -0,0 +1,28 @@ +import React from 'react'; +import ReactDOMServer from 'react-dom/server'; + +export function __react_static(ReactComponent: any) { + return (attrs: Record, ...children: any): string => { + let html = ReactDOMServer.renderToString( + React.createElement( + ReactComponent, + attrs, + children + ) + ); + return html; + }; +} + +export function __react_dynamic(ReactComponent: any, importUrl: string, reactUrl: string, reactDomUrl: string) { + const placeholderId = `placeholder_${String(Math.random())}`; + return (attrs: Record, ...children: any) => { + return `
`; + }; +} diff --git a/src/runtime.ts b/src/runtime.ts index 18bacb6eb163..ed498c3316a3 100644 --- a/src/runtime.ts +++ b/src/runtime.ts @@ -96,12 +96,15 @@ async function load(config: RuntimeConfig, rawPathname: string | undefined): Pro } export async function createRuntime(astroConfig: AstroConfig, logging: LogOptions) { - const { projectRoot, hmxRoot } = astroConfig; + const { projectRoot, hmxRoot, extensions } = astroConfig; const internalPath = new URL('./frontend/', import.meta.url); // Workaround for SKY-251 - const hmxPlugOptions: { resolve?: (s: string) => string } = {}; + const hmxPlugOptions: { + resolve?: (s: string) => string; + extensions?: Record + } = { extensions }; if (existsSync(new URL('./package-lock.json', projectRoot))) { const pkgLockStr = await readFile(new URL('./package-lock.json', projectRoot), 'utf-8'); const pkgLock = JSON.parse(pkgLockStr); @@ -125,7 +128,10 @@ export async function createRuntime(astroConfig: AstroConfig, logging: LogOption }, packageOptions: { knownEntrypoints: ['preact-render-to-string'], - external: ['@vue/server-renderer'], + external: [ + '@vue/server-renderer', + 'node-fetch' + ], }, }); const snowpack = await startSnowpackServer({ diff --git a/test/fixtures/react-component/astro.config.mjs b/test/fixtures/react-component/astro.config.mjs new file mode 100644 index 000000000000..3a3006dd8fc5 --- /dev/null +++ b/test/fixtures/react-component/astro.config.mjs @@ -0,0 +1,7 @@ + +export default { + projectRoot: '.', + hmxRoot: './astro', + dist: './_site' + // No extensions needed, React is the default. +} \ No newline at end of file diff --git a/test/fixtures/react-component/astro/components/Hello.jsx b/test/fixtures/react-component/astro/components/Hello.jsx new file mode 100644 index 000000000000..d4be8a8fb1e3 --- /dev/null +++ b/test/fixtures/react-component/astro/components/Hello.jsx @@ -0,0 +1,5 @@ +import React from 'react'; + +export default function({ name }) { + return

Hello {name}!

+} \ No newline at end of file diff --git a/test/fixtures/react-component/astro/pages/index.hmx b/test/fixtures/react-component/astro/pages/index.hmx new file mode 100644 index 000000000000..8616754cabe1 --- /dev/null +++ b/test/fixtures/react-component/astro/pages/index.hmx @@ -0,0 +1,10 @@ + + + + + + +

My page

+ \ No newline at end of file diff --git a/test/fixtures/react-component/snowpack.config.js b/test/fixtures/react-component/snowpack.config.js new file mode 100644 index 000000000000..2cbf0ef07ed8 --- /dev/null +++ b/test/fixtures/react-component/snowpack.config.js @@ -0,0 +1,5 @@ +export default { + mount: { + + } +}; diff --git a/test/react-component.test.js b/test/react-component.test.js new file mode 100644 index 000000000000..c22249abfb23 --- /dev/null +++ b/test/react-component.test.js @@ -0,0 +1,35 @@ +import { suite } from 'uvu'; +import * as assert from 'uvu/assert'; +import { createRuntime } from '../lib/runtime.js'; +import { loadConfig } from '../lib/config.js'; +import { doc } from './test-utils.js'; + +const React = suite('React Components'); + +let runtime; + +React.before(async () => { + const astroConfig = await loadConfig(new URL('./fixtures/react-component', import.meta.url).pathname); + + const logging = { + level: 'error', + dest: process.stderr + }; + + runtime = await createRuntime(astroConfig, logging); +}); + +React.after(async () => { + await runtime.shutdown(); +}); + +React.only('Can load hmx page', async () => { + const result = await runtime.load('/'); + + assert.equal(result.statusCode, 200); + + const $ = doc(result.contents); + assert.equal($('h2').text(), 'Hello world!'); +}); + +React.run(); \ No newline at end of file diff --git a/test/snowpack-integration.test.js b/test/snowpack-integration.test.js index c851e8bdbbc4..9f76aed88d26 100644 --- a/test/snowpack-integration.test.js +++ b/test/snowpack-integration.test.js @@ -1,6 +1,7 @@ import { suite } from 'uvu'; import * as assert from 'uvu/assert'; import { createRuntime } from '../lib/runtime.js'; +import { loadConfig } from '../lib/config.js'; import { promises as fsPromises } from 'fs'; import { relative as pathRelative } from 'path'; import { doc } from './test-utils.js'; @@ -15,11 +16,7 @@ const SnowpackDev = suite('snowpack.dev'); let runtime; SnowpackDev.before(async () => { - const astroConfig = { - projectRoot: new URL('../examples/snowpack/', import.meta.url), - hmxRoot: new URL('../examples/snowpack/astro/', import.meta.url), - dist: './_site', - }; + const astroConfig = await loadConfig(new URL('../examples/snowpack', import.meta.url).pathname); const logging = { level: 'error', From 2e90601b9c879e5c94e04d5c6c9418a9c27b4fff Mon Sep 17 00:00:00 2001 From: Matthew Phillips Date: Tue, 23 Mar 2021 09:59:40 -0400 Subject: [PATCH 2/2] Fix the tests --- examples/snowpack/astro/layouts/post.hmx | 1 + examples/snowpack/package-lock.json | 131 ++++++++++++++++++++++- package-lock.json | 63 +++-------- test/react-component.test.js | 9 +- test/snowpack-integration.test.js | 17 ++- 5 files changed, 161 insertions(+), 60 deletions(-) diff --git a/examples/snowpack/astro/layouts/post.hmx b/examples/snowpack/astro/layouts/post.hmx index 357af9c68d91..e0b87afbf1a9 100644 --- a/examples/snowpack/astro/layouts/post.hmx +++ b/examples/snowpack/astro/layouts/post.hmx @@ -72,6 +72,7 @@ .grid-body { padding: 20px 0 0 0; } + } .header-snowpack { font-size: 3.5rem; diff --git a/examples/snowpack/package-lock.json b/examples/snowpack/package-lock.json index d4575f17a9a2..836a89da265c 100644 --- a/examples/snowpack/package-lock.json +++ b/examples/snowpack/package-lock.json @@ -1294,7 +1294,7 @@ "react": "^17.0.1", "react-dom": "^17.0.1", "sass": "^1.32.8", - "snowpack": "^3.1.0-pre.13", + "snowpack": "^3.1.0-pre.14", "svelte": "^3.35.0", "vue": "^3.0.7", "yargs-parser": "^20.2.7" @@ -1469,12 +1469,14 @@ "@types/prop-types": { "version": "15.7.3", "resolved": "https://registry.npmjs.org/@types/prop-types/-/prop-types-15.7.3.tgz", - "integrity": "sha512-KfRL3PuHmqQLOG+2tGpRO26Ctg+Cq1E01D2DMriKEATHgWLfeNDmq9e29Q9WIky0dQ3NPkd1mzYH8Lm936Z9qw==" + "integrity": "sha512-KfRL3PuHmqQLOG+2tGpRO26Ctg+Cq1E01D2DMriKEATHgWLfeNDmq9e29Q9WIky0dQ3NPkd1mzYH8Lm936Z9qw==", + "dev": true }, "@types/react": { "version": "17.0.3", "resolved": "https://registry.npmjs.org/@types/react/-/react-17.0.3.tgz", "integrity": "sha512-wYOUxIgs2HZZ0ACNiIayItyluADNbONl7kt8lkLjVK8IitMH5QMyAh75Fwhmo37r1m7L2JaFj03sIfxBVDvRAg==", + "dev": true, "requires": { "@types/prop-types": "*", "@types/scheduler": "*", @@ -1484,7 +1486,8 @@ "csstype": { "version": "3.0.7", "resolved": "https://registry.npmjs.org/csstype/-/csstype-3.0.7.tgz", - "integrity": "sha512-KxnUB0ZMlnUWCsx2Z8MUsr6qV6ja1w9ArPErJaJaF8a5SOWoHLIszeCTKGRGRgtLgYrs1E8CHkNSP1VZTTPc9g==" + "integrity": "sha512-KxnUB0ZMlnUWCsx2Z8MUsr6qV6ja1w9ArPErJaJaF8a5SOWoHLIszeCTKGRGRgtLgYrs1E8CHkNSP1VZTTPc9g==", + "dev": true } } }, @@ -1492,6 +1495,7 @@ "version": "17.0.2", "resolved": "https://registry.npmjs.org/@types/react-dom/-/react-dom-17.0.2.tgz", "integrity": "sha512-Icd9KEgdnFfJs39KyRyr0jQ7EKhq8U6CcHRMGAS45fp5qgUvxL3ujUCfWFttUK2UErqZNj97t9gsVPNAqcwoCg==", + "dev": true, "requires": { "@types/react": "*" } @@ -1507,7 +1511,8 @@ "@types/scheduler": { "version": "0.16.1", "resolved": "https://registry.npmjs.org/@types/scheduler/-/scheduler-0.16.1.tgz", - "integrity": "sha512-EaCxbanVeyxDRTQBkdLb3Bvl/HK7PBK6UJjsSixB0iHKoWxE5uu2Q/DgtpOhPIojN0Zl1whvOd7PoHs2P0s5eA==" + "integrity": "sha512-EaCxbanVeyxDRTQBkdLb3Bvl/HK7PBK6UJjsSixB0iHKoWxE5uu2Q/DgtpOhPIojN0Zl1whvOd7PoHs2P0s5eA==", + "dev": true }, "@types/yargs-parser": { "version": "20.2.0", @@ -1823,6 +1828,12 @@ "resolved": "https://registry.npmjs.org/balanced-match/-/balanced-match-1.0.0.tgz", "integrity": "sha1-ibTRmasr7kneFk6gK4nORi1xt2c=" }, + "big-integer": { + "version": "1.6.48", + "resolved": "https://registry.npmjs.org/big-integer/-/big-integer-1.6.48.tgz", + "integrity": "sha512-j51egjPa7/i+RdiRuJbPdJ2FIUYYPhvYLjzoYbcMMm62ooO6F94fETG4MTs46zPAF9Brs04OajboA/qTGuz78w==", + "dev": true + }, "big.js": { "version": "5.2.2", "resolved": "https://registry.npmjs.org/big.js/-/big.js-5.2.2.tgz", @@ -1854,6 +1865,15 @@ "widest-line": "^3.1.0" } }, + "bplist-parser": { + "version": "0.1.1", + "resolved": "https://registry.npmjs.org/bplist-parser/-/bplist-parser-0.1.1.tgz", + "integrity": "sha1-1g1dzCDLptx+HymbNdPh+V2vuuY=", + "dev": true, + "requires": { + "big-integer": "^1.6.7" + } + }, "brace-expansion": { "version": "1.1.11", "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-1.1.11.tgz", @@ -2022,6 +2042,12 @@ "resolved": "https://registry.npmjs.org/cli-boxes/-/cli-boxes-2.2.1.tgz", "integrity": "sha512-y4coMcylgSCdVinjiDBuR8PCC2bLjyGTwEmPb9NHR/QaNU6EUOXcTY/s6VjGMD6ENSEaeQYHCY0GNGS5jfMwPw==" }, + "cli-spinners": { + "version": "2.6.0", + "resolved": "https://registry.npmjs.org/cli-spinners/-/cli-spinners-2.6.0.tgz", + "integrity": "sha512-t+4/y50K/+4xcCRosKkA7W4gTr1MySvLV0q+PxmG7FJ5g+66ChKurYjxBCjHggHH3HA5Hh9cy+lcUGWDqVH+4Q==", + "dev": true + }, "cliui": { "version": "7.0.4", "resolved": "https://registry.npmjs.org/cliui/-/cliui-7.0.4.tgz", @@ -2252,6 +2278,28 @@ "integrity": "sha512-FJ3UgI4gIl+PHZm53knsuSFpE+nESMr7M4v9QcgB7S63Kj/6WqMiFQJpBBYz1Pt+66bZpP3Q7Lye0Oo9MPKEdg==", "dev": true }, + "default-browser-id": { + "version": "2.0.0", + "resolved": "https://registry.npmjs.org/default-browser-id/-/default-browser-id-2.0.0.tgz", + "integrity": "sha1-AezONxpx6F8VoXF354YwR+c9vn0=", + "dev": true, + "requires": { + "bplist-parser": "^0.1.0", + "pify": "^2.3.0", + "untildify": "^2.0.0" + }, + "dependencies": { + "untildify": { + "version": "2.1.0", + "resolved": "https://registry.npmjs.org/untildify/-/untildify-2.1.0.tgz", + "integrity": "sha1-F+soB5h/dpUunASF/DEdBqgmouA=", + "dev": true, + "requires": { + "os-homedir": "^1.0.0" + } + } + } + }, "defer-to-connect": { "version": "1.1.3", "resolved": "https://registry.npmjs.org/defer-to-connect/-/defer-to-connect-1.1.3.tgz", @@ -2388,6 +2436,12 @@ "integrity": "sha512-ooYciCUtfw6/d2w56UVeqHPcoCFAiJdz5XOkYpv/Txl1HMUozpXjz/2RIQgqwKdXNDPSF1W7mJCFse3G+HDyAA==", "dev": true }, + "esbuild": { + "version": "0.9.6", + "resolved": "https://registry.npmjs.org/esbuild/-/esbuild-0.9.6.tgz", + "integrity": "sha512-F6vASxU0wT/Davt9aj2qtDwDNSkQxh9VbyO56M7PDWD+D/Vgq/rmUDGDQo7te76W5auauVojjnQr/wTu3vpaUA==", + "dev": true + }, "escalade": { "version": "3.1.1", "resolved": "https://registry.npmjs.org/escalade/-/escalade-3.1.1.tgz", @@ -2669,6 +2723,12 @@ "reusify": "^1.0.4" } }, + "fdir": { + "version": "5.0.0", + "resolved": "https://registry.npmjs.org/fdir/-/fdir-5.0.0.tgz", + "integrity": "sha512-cteqwWMA43lEmgwOg5HSdvhVFD39vHjQDhZkRMlKmeoNPtSSgUw1nUypydiY2upMdGiBFBZvNBDbnoBh0yCzaQ==", + "dev": true + }, "file-entry-cache": { "version": "6.0.1", "resolved": "https://registry.npmjs.org/file-entry-cache/-/file-entry-cache-6.0.1.tgz", @@ -3045,6 +3105,12 @@ "integrity": "sha512-RGdriMmQQvZ2aqaQq3awNA6dCGtKpiDFcOzrTWrDAT2MiWrKQVPmxLGHl7Y2nNu6led0kEyoX0enY0qXYsv9zw==", "dev": true }, + "is-docker": { + "version": "2.1.1", + "resolved": "https://registry.npmjs.org/is-docker/-/is-docker-2.1.1.tgz", + "integrity": "sha512-ZOoqiXfEwtGknTiuDEy8pN2CfE3TxMHprvNer1mXiqwkOT77Rw3YVrUQ52EqAOU3QAWDQ+bQdx7HJzrv7LS2Hw==", + "dev": true + }, "is-extendable": { "version": "0.1.1", "resolved": "https://registry.npmjs.org/is-extendable/-/is-extendable-0.1.1.tgz", @@ -3109,6 +3175,15 @@ "resolved": "https://registry.npmjs.org/is-typedarray/-/is-typedarray-1.0.0.tgz", "integrity": "sha1-5HnICFjfDBsR3dppQPlgEfzaSpo=" }, + "is-wsl": { + "version": "2.2.0", + "resolved": "https://registry.npmjs.org/is-wsl/-/is-wsl-2.2.0.tgz", + "integrity": "sha512-fKzAra0rGJUUBwGBgNkHZuToZcn+TtXHpeCgmkMJMMYx1sQDYaCSyjJBSCa2nH1DGm7s3n1oBnohoVTBaN7Lww==", + "dev": true, + "requires": { + "is-docker": "^2.0.0" + } + }, "is-yarn-global": { "version": "0.3.0", "resolved": "https://registry.npmjs.org/is-yarn-global/-/is-yarn-global-0.3.0.tgz", @@ -3517,6 +3592,16 @@ "wrappy": "1" } }, + "open": { + "version": "7.4.2", + "resolved": "https://registry.npmjs.org/open/-/open-7.4.2.tgz", + "integrity": "sha512-MVHddDVweXZF3awtlAS+6pgKLlm/JgxZ90+/NBurBoQctVOOB/zDdVjcyPzQ+0laDGbsWgrRkflI65sQeOgT9Q==", + "dev": true, + "requires": { + "is-docker": "^2.0.0", + "is-wsl": "^2.1.1" + } + }, "optionator": { "version": "0.9.1", "resolved": "https://registry.npmjs.org/optionator/-/optionator-0.9.1.tgz", @@ -3530,6 +3615,12 @@ "word-wrap": "^1.2.3" } }, + "os-homedir": { + "version": "1.0.2", + "resolved": "https://registry.npmjs.org/os-homedir/-/os-homedir-1.0.2.tgz", + "integrity": "sha1-/7xJiDNuDoM94MFox+8VISGqf7M=", + "dev": true + }, "p-cancelable": { "version": "1.1.0", "resolved": "https://registry.npmjs.org/p-cancelable/-/p-cancelable-1.1.0.tgz", @@ -3624,6 +3715,12 @@ "resolved": "https://registry.npmjs.org/picomatch/-/picomatch-2.2.2.tgz", "integrity": "sha512-q0M/9eZHzmr0AulXyPwNfZjtwZ/RBZlbN3K3CErVrk50T2ASYI7Bye0EvekFY3IP1Nt2DHu0re+V2ZHIpMkuWg==" }, + "pify": { + "version": "2.3.0", + "resolved": "https://registry.npmjs.org/pify/-/pify-2.3.0.tgz", + "integrity": "sha1-7RQaasBDqEnqWISY59yosVMw6Qw=", + "dev": true + }, "postcss": { "version": "8.2.8", "resolved": "https://registry.npmjs.org/postcss/-/postcss-8.2.8.tgz", @@ -3922,6 +4019,15 @@ "glob": "^7.1.3" } }, + "rollup": { + "version": "2.42.3", + "resolved": "https://registry.npmjs.org/rollup/-/rollup-2.42.3.tgz", + "integrity": "sha512-JjaT9WaUS5vmjy6xUrnPOskjkQg2cN4WSACNCwbOvBz8VDmbiKVdmTFUoMPRqTud0tsex8Xy9/boLbDW9HKD1w==", + "dev": true, + "requires": { + "fsevents": "~2.3.1" + } + }, "run-parallel": { "version": "1.2.0", "resolved": "https://registry.npmjs.org/run-parallel/-/run-parallel-1.2.0.tgz", @@ -4028,6 +4134,23 @@ "is-fullwidth-code-point": "^3.0.0" } }, + "snowpack": { + "version": "3.1.2", + "resolved": "https://registry.npmjs.org/snowpack/-/snowpack-3.1.2.tgz", + "integrity": "sha512-LsYlBNjB/t/p5QP434Pa1TqjyuX8VtXiYQaAWZkOn1d1TVKEt7nigMBr8Z+EDXYn6YlLXYKHXDvv/NhUS7Ri9A==", + "dev": true, + "requires": { + "cli-spinners": "^2.5.0", + "default-browser-id": "^2.0.0", + "esbuild": "^0.9.3", + "fdir": "^5.0.0", + "fsevents": "^2.2.0", + "open": "^7.0.4", + "picomatch": "^2.2.2", + "resolve": "^1.20.0", + "rollup": "^2.34.0" + } + }, "source-map": { "version": "0.6.1", "resolved": "https://registry.npmjs.org/source-map/-/source-map-0.6.1.tgz", diff --git a/package-lock.json b/package-lock.json index 7381f6d2f774..edae85947d36 100644 --- a/package-lock.json +++ b/package-lock.json @@ -510,7 +510,6 @@ "version": "3.1.1", "resolved": "https://registry.npmjs.org/anymatch/-/anymatch-3.1.1.tgz", "integrity": "sha512-mM8522psRCqzV+6LhomX5wgp25YVibjh8Wj23I5RPkPppSVSjyKD2A2mBJmWGa+KN7f2D6LNh9jkBCeyLktzjg==", - "dev": true, "requires": { "normalize-path": "^3.0.0", "picomatch": "^2.0.4" @@ -563,8 +562,7 @@ "big-integer": { "version": "1.6.48", "resolved": "https://registry.npmjs.org/big-integer/-/big-integer-1.6.48.tgz", - "integrity": "sha512-j51egjPa7/i+RdiRuJbPdJ2FIUYYPhvYLjzoYbcMMm62ooO6F94fETG4MTs46zPAF9Brs04OajboA/qTGuz78w==", - "dev": true + "integrity": "sha512-j51egjPa7/i+RdiRuJbPdJ2FIUYYPhvYLjzoYbcMMm62ooO6F94fETG4MTs46zPAF9Brs04OajboA/qTGuz78w==" }, "big.js": { "version": "5.2.2", @@ -574,8 +572,7 @@ "binary-extensions": { "version": "2.2.0", "resolved": "https://registry.npmjs.org/binary-extensions/-/binary-extensions-2.2.0.tgz", - "integrity": "sha512-jDctJ/IVQbZoJykoeHbhXpOlNBqGNcwXJKJog42E5HDPUwQTSdjCHdihjj0DlnheQ7blbT6dHOafNAiS8ooQKA==", - "dev": true + "integrity": "sha512-jDctJ/IVQbZoJykoeHbhXpOlNBqGNcwXJKJog42E5HDPUwQTSdjCHdihjj0DlnheQ7blbT6dHOafNAiS8ooQKA==" }, "boolbase": { "version": "1.0.0", @@ -603,7 +600,6 @@ "version": "0.1.1", "resolved": "https://registry.npmjs.org/bplist-parser/-/bplist-parser-0.1.1.tgz", "integrity": "sha1-1g1dzCDLptx+HymbNdPh+V2vuuY=", - "dev": true, "requires": { "big-integer": "^1.6.7" } @@ -622,7 +618,6 @@ "version": "3.0.2", "resolved": "https://registry.npmjs.org/braces/-/braces-3.0.2.tgz", "integrity": "sha512-b8um+L1RzM3WDSzvhm6gIz1yfTbBt6YTlcEKAvsmqCZZFw46z626lVj9j1yEPW33H5H+lBQpZMP1k8l+78Ha0A==", - "dev": true, "requires": { "fill-range": "^7.0.1" } @@ -762,7 +757,6 @@ "version": "3.5.1", "resolved": "https://registry.npmjs.org/chokidar/-/chokidar-3.5.1.tgz", "integrity": "sha512-9+s+Od+W0VJJzawDma/gvBNQqkTiqYTWLuZoyAsivsI4AaWTCzHG06/TMjsf1cYe9Cb97UCEhjz7HvnPk2p/tw==", - "dev": true, "requires": { "anymatch": "~3.1.1", "braces": "~3.0.2", @@ -789,8 +783,7 @@ "cli-spinners": { "version": "2.6.0", "resolved": "https://registry.npmjs.org/cli-spinners/-/cli-spinners-2.6.0.tgz", - "integrity": "sha512-t+4/y50K/+4xcCRosKkA7W4gTr1MySvLV0q+PxmG7FJ5g+66ChKurYjxBCjHggHH3HA5Hh9cy+lcUGWDqVH+4Q==", - "dev": true + "integrity": "sha512-t+4/y50K/+4xcCRosKkA7W4gTr1MySvLV0q+PxmG7FJ5g+66ChKurYjxBCjHggHH3HA5Hh9cy+lcUGWDqVH+4Q==" }, "cliui": { "version": "7.0.4", @@ -1044,7 +1037,6 @@ "version": "2.0.0", "resolved": "https://registry.npmjs.org/default-browser-id/-/default-browser-id-2.0.0.tgz", "integrity": "sha1-AezONxpx6F8VoXF354YwR+c9vn0=", - "dev": true, "requires": { "bplist-parser": "^0.1.0", "pify": "^2.3.0", @@ -1055,7 +1047,6 @@ "version": "2.1.0", "resolved": "https://registry.npmjs.org/untildify/-/untildify-2.1.0.tgz", "integrity": "sha1-F+soB5h/dpUunASF/DEdBqgmouA=", - "dev": true, "requires": { "os-homedir": "^1.0.0" } @@ -1213,8 +1204,7 @@ "esbuild": { "version": "0.9.6", "resolved": "https://registry.npmjs.org/esbuild/-/esbuild-0.9.6.tgz", - "integrity": "sha512-F6vASxU0wT/Davt9aj2qtDwDNSkQxh9VbyO56M7PDWD+D/Vgq/rmUDGDQo7te76W5auauVojjnQr/wTu3vpaUA==", - "dev": true + "integrity": "sha512-F6vASxU0wT/Davt9aj2qtDwDNSkQxh9VbyO56M7PDWD+D/Vgq/rmUDGDQo7te76W5auauVojjnQr/wTu3vpaUA==" }, "escalade": { "version": "3.1.1", @@ -1532,8 +1522,7 @@ "fdir": { "version": "5.0.0", "resolved": "https://registry.npmjs.org/fdir/-/fdir-5.0.0.tgz", - "integrity": "sha512-cteqwWMA43lEmgwOg5HSdvhVFD39vHjQDhZkRMlKmeoNPtSSgUw1nUypydiY2upMdGiBFBZvNBDbnoBh0yCzaQ==", - "dev": true + "integrity": "sha512-cteqwWMA43lEmgwOg5HSdvhVFD39vHjQDhZkRMlKmeoNPtSSgUw1nUypydiY2upMdGiBFBZvNBDbnoBh0yCzaQ==" }, "file-entry-cache": { "version": "6.0.1", @@ -1548,7 +1537,6 @@ "version": "7.0.1", "resolved": "https://registry.npmjs.org/fill-range/-/fill-range-7.0.1.tgz", "integrity": "sha512-qOo9F+dMUmC2Lcb4BbVvnKJxTPjCm+RRpe4gDuGrzkL7mEVl/djYSu2OdQ2Pa302N4oqkSg9ir6jaLWJ2USVpQ==", - "dev": true, "requires": { "to-regex-range": "^5.0.1" } @@ -1589,8 +1577,7 @@ "function-bind": { "version": "1.1.1", "resolved": "https://registry.npmjs.org/function-bind/-/function-bind-1.1.1.tgz", - "integrity": "sha512-yIovAzMX49sF8Yl58fSCWJ5svSLuaibPxXQJFLmBObTuCr0Mf1KiPopGM9NiFjiYBCbfaa2Fh6breQ6ANVTI0A==", - "dev": true + "integrity": "sha512-yIovAzMX49sF8Yl58fSCWJ5svSLuaibPxXQJFLmBObTuCr0Mf1KiPopGM9NiFjiYBCbfaa2Fh6breQ6ANVTI0A==" }, "functional-red-black-tree": { "version": "1.0.1", @@ -1654,7 +1641,6 @@ "version": "5.1.2", "resolved": "https://registry.npmjs.org/glob-parent/-/glob-parent-5.1.2.tgz", "integrity": "sha512-AOIgSQCepiJYwP3ARnGx+5VnTu2HBYdzbGP45eLw1vr3zB3vZLeyed1sC9hnbcOc9/SrMyM5RPQrkGz4aS9Zow==", - "dev": true, "requires": { "is-glob": "^4.0.1" } @@ -1739,7 +1725,6 @@ "version": "1.0.3", "resolved": "https://registry.npmjs.org/has/-/has-1.0.3.tgz", "integrity": "sha512-f2dvO0VU6Oej7RkWJGrehjbzMAjFp5/VKPp5tTpWIV4JHHZK1/BxbFRtf/siA2SWTe09caDmVtYYzWEIbBS4zw==", - "dev": true, "requires": { "function-bind": "^1.1.1" } @@ -1906,7 +1891,6 @@ "version": "2.1.0", "resolved": "https://registry.npmjs.org/is-binary-path/-/is-binary-path-2.1.0.tgz", "integrity": "sha512-ZMERYes6pDydyuGidse7OsHxtbI7WVeUEozgR/g7rd0xUimYNlvZRE/K2MgZTjWy725IfelLeVcEM97mmtRGXw==", - "dev": true, "requires": { "binary-extensions": "^2.0.0" } @@ -1924,7 +1908,6 @@ "version": "2.2.0", "resolved": "https://registry.npmjs.org/is-core-module/-/is-core-module-2.2.0.tgz", "integrity": "sha512-XRAfAdyyY5F5cOXn7hYQDqh2Xmii+DEfIcQGxK/uNwMHhIkPWO0g8msXcbzLe+MpGoR951MlqM/2iIlU4vKDdQ==", - "dev": true, "requires": { "has": "^1.0.3" } @@ -1937,8 +1920,7 @@ "is-docker": { "version": "2.1.1", "resolved": "https://registry.npmjs.org/is-docker/-/is-docker-2.1.1.tgz", - "integrity": "sha512-ZOoqiXfEwtGknTiuDEy8pN2CfE3TxMHprvNer1mXiqwkOT77Rw3YVrUQ52EqAOU3QAWDQ+bQdx7HJzrv7LS2Hw==", - "dev": true + "integrity": "sha512-ZOoqiXfEwtGknTiuDEy8pN2CfE3TxMHprvNer1mXiqwkOT77Rw3YVrUQ52EqAOU3QAWDQ+bQdx7HJzrv7LS2Hw==" }, "is-extendable": { "version": "0.1.1", @@ -1948,8 +1930,7 @@ "is-extglob": { "version": "2.1.1", "resolved": "https://registry.npmjs.org/is-extglob/-/is-extglob-2.1.1.tgz", - "integrity": "sha1-qIwCU1eR8C7TfHahueqXc8gz+MI=", - "dev": true + "integrity": "sha1-qIwCU1eR8C7TfHahueqXc8gz+MI=" }, "is-fullwidth-code-point": { "version": "3.0.0", @@ -1961,7 +1942,6 @@ "version": "4.0.1", "resolved": "https://registry.npmjs.org/is-glob/-/is-glob-4.0.1.tgz", "integrity": "sha512-5G0tKtBTFImOqDnLB2hG6Bp2qcKEFduo4tZu9MT/H6NQv/ghhy30o55ufafxJ/LdH79LLs2Kfrn85TLKyA7BUg==", - "dev": true, "requires": { "is-extglob": "^2.1.1" } @@ -1990,8 +1970,7 @@ "is-number": { "version": "7.0.0", "resolved": "https://registry.npmjs.org/is-number/-/is-number-7.0.0.tgz", - "integrity": "sha512-41Cifkg6e8TylSpdtTpeLVMqvSBEVzTttHvERD741+pnZ8ANv0004MRL43QKPDlK9cGvNp6NZWZUBlbGXYxxng==", - "dev": true + "integrity": "sha512-41Cifkg6e8TylSpdtTpeLVMqvSBEVzTttHvERD741+pnZ8ANv0004MRL43QKPDlK9cGvNp6NZWZUBlbGXYxxng==" }, "is-obj": { "version": "2.0.0", @@ -2015,7 +1994,6 @@ "version": "2.2.0", "resolved": "https://registry.npmjs.org/is-wsl/-/is-wsl-2.2.0.tgz", "integrity": "sha512-fKzAra0rGJUUBwGBgNkHZuToZcn+TtXHpeCgmkMJMMYx1sQDYaCSyjJBSCa2nH1DGm7s3n1oBnohoVTBaN7Lww==", - "dev": true, "requires": { "is-docker": "^2.0.0" } @@ -2275,7 +2253,6 @@ "version": "4.0.2", "resolved": "https://registry.npmjs.org/micromatch/-/micromatch-4.0.2.tgz", "integrity": "sha512-y7FpHSbMUMoyPbYUSzO6PaZ6FyRnQOpHuKwbo1G+Knck95XVU4QAiKdGEnj5wwoS7PlOgthX/09u5iFJ+aYf5Q==", - "dev": true, "requires": { "braces": "^3.0.1", "picomatch": "^2.0.5" @@ -2402,8 +2379,7 @@ "normalize-path": { "version": "3.0.0", "resolved": "https://registry.npmjs.org/normalize-path/-/normalize-path-3.0.0.tgz", - "integrity": "sha512-6eZs5Ls3WtCisHWp9S2GUy8dqkpGi4BVSz3GaqiE6ezub0512ESztXUwUB6C6IKbQkY2Pnb/mD4WYojCRwcwLA==", - "dev": true + "integrity": "sha512-6eZs5Ls3WtCisHWp9S2GUy8dqkpGi4BVSz3GaqiE6ezub0512ESztXUwUB6C6IKbQkY2Pnb/mD4WYojCRwcwLA==" }, "normalize-range": { "version": "0.1.2", @@ -2443,7 +2419,6 @@ "version": "7.4.2", "resolved": "https://registry.npmjs.org/open/-/open-7.4.2.tgz", "integrity": "sha512-MVHddDVweXZF3awtlAS+6pgKLlm/JgxZ90+/NBurBoQctVOOB/zDdVjcyPzQ+0laDGbsWgrRkflI65sQeOgT9Q==", - "dev": true, "requires": { "is-docker": "^2.0.0", "is-wsl": "^2.1.1" @@ -2466,8 +2441,7 @@ "os-homedir": { "version": "1.0.2", "resolved": "https://registry.npmjs.org/os-homedir/-/os-homedir-1.0.2.tgz", - "integrity": "sha1-/7xJiDNuDoM94MFox+8VISGqf7M=", - "dev": true + "integrity": "sha1-/7xJiDNuDoM94MFox+8VISGqf7M=" }, "p-cancelable": { "version": "1.1.0", @@ -2559,8 +2533,7 @@ "path-parse": { "version": "1.0.6", "resolved": "https://registry.npmjs.org/path-parse/-/path-parse-1.0.6.tgz", - "integrity": "sha512-GSmOT2EbHrINBf9SR7CDELwlJ8AENk3Qn7OikK4nFYAu3Ote2+JYNVvkpAEQm3/TLNEJFD/xZJjzyxg3KBWOzw==", - "dev": true + "integrity": "sha512-GSmOT2EbHrINBf9SR7CDELwlJ8AENk3Qn7OikK4nFYAu3Ote2+JYNVvkpAEQm3/TLNEJFD/xZJjzyxg3KBWOzw==" }, "path-type": { "version": "4.0.0", @@ -2571,14 +2544,12 @@ "picomatch": { "version": "2.2.2", "resolved": "https://registry.npmjs.org/picomatch/-/picomatch-2.2.2.tgz", - "integrity": "sha512-q0M/9eZHzmr0AulXyPwNfZjtwZ/RBZlbN3K3CErVrk50T2ASYI7Bye0EvekFY3IP1Nt2DHu0re+V2ZHIpMkuWg==", - "dev": true + "integrity": "sha512-q0M/9eZHzmr0AulXyPwNfZjtwZ/RBZlbN3K3CErVrk50T2ASYI7Bye0EvekFY3IP1Nt2DHu0re+V2ZHIpMkuWg==" }, "pify": { "version": "2.3.0", "resolved": "https://registry.npmjs.org/pify/-/pify-2.3.0.tgz", - "integrity": "sha1-7RQaasBDqEnqWISY59yosVMw6Qw=", - "dev": true + "integrity": "sha1-7RQaasBDqEnqWISY59yosVMw6Qw=" }, "postcss": { "version": "8.2.8", @@ -2816,7 +2787,6 @@ "version": "3.5.0", "resolved": "https://registry.npmjs.org/readdirp/-/readdirp-3.5.0.tgz", "integrity": "sha512-cMhu7c/8rdhkHXWsY+osBhfSy0JikwpHK/5+imo+LpeasTF8ouErHrlYkwT0++njiyuDvc7OFY5T3ukvZ8qmFQ==", - "dev": true, "requires": { "picomatch": "^2.2.1" } @@ -2861,7 +2831,6 @@ "version": "1.20.0", "resolved": "https://registry.npmjs.org/resolve/-/resolve-1.20.0.tgz", "integrity": "sha512-wENBPt4ySzg4ybFQW2TT1zMQucPK95HSh/nq2CFTZVOGut2+pQvSsgtda4d26YrYcr067wjbmzOG8byDPBX63A==", - "dev": true, "requires": { "is-core-module": "^2.2.0", "path-parse": "^1.0.6" @@ -2901,7 +2870,6 @@ "version": "2.42.3", "resolved": "https://registry.npmjs.org/rollup/-/rollup-2.42.3.tgz", "integrity": "sha512-JjaT9WaUS5vmjy6xUrnPOskjkQg2cN4WSACNCwbOvBz8VDmbiKVdmTFUoMPRqTud0tsex8Xy9/boLbDW9HKD1w==", - "dev": true, "requires": { "fsevents": "~2.3.1" } @@ -2937,7 +2905,6 @@ "version": "1.32.8", "resolved": "https://registry.npmjs.org/sass/-/sass-1.32.8.tgz", "integrity": "sha512-Sl6mIeGpzjIUZqvKnKETfMf0iDAswD9TNlv13A7aAF3XZlRPMq4VvJWBC2N2DXbp94MQVdNSFG6LfF/iOXrPHQ==", - "dev": true, "requires": { "chokidar": ">=2.0.0 <4.0.0" } @@ -3025,7 +2992,6 @@ "version": "3.1.0-pre.14", "resolved": "https://registry.npmjs.org/snowpack/-/snowpack-3.1.0-pre.14.tgz", "integrity": "sha512-NJm+XOMHryrDPWkqpqqBjQLZcSrs8WzW84H0vs3m10kFD1vvOBqPrD5ECH3fRVre314wA3arOgZbWGhY27A29w==", - "dev": true, "requires": { "cli-spinners": "^2.5.0", "default-browser-id": "^2.0.0", @@ -3271,7 +3237,6 @@ "version": "5.0.1", "resolved": "https://registry.npmjs.org/to-regex-range/-/to-regex-range-5.0.1.tgz", "integrity": "sha512-65P7iz6X5yEr1cwcgvQxbbIw7Uk3gOy5dIdtZ4rDveLqhrdJP+Li/Hx6tyK0NEb+2GCyneCMJiGqrADCSNk8sQ==", - "dev": true, "requires": { "is-number": "^7.0.0" } diff --git a/test/react-component.test.js b/test/react-component.test.js index c22249abfb23..0b627392227d 100644 --- a/test/react-component.test.js +++ b/test/react-component.test.js @@ -16,14 +16,19 @@ React.before(async () => { dest: process.stderr }; - runtime = await createRuntime(astroConfig, logging); + try { + runtime = await createRuntime(astroConfig, logging); + } catch(err) { + console.error(err); + throw err; + } }); React.after(async () => { await runtime.shutdown(); }); -React.only('Can load hmx page', async () => { +React('Can load hmx page', async () => { const result = await runtime.load('/'); assert.equal(result.statusCode, 200); diff --git a/test/snowpack-integration.test.js b/test/snowpack-integration.test.js index 9f76aed88d26..8547ee7cdfa3 100644 --- a/test/snowpack-integration.test.js +++ b/test/snowpack-integration.test.js @@ -8,14 +8,15 @@ import { doc } from './test-utils.js'; const { readdir, stat } = fsPromises; -// Bug: Snowpack config is still loaded relative to the current working directory. -process.chdir(new URL('../examples/snowpack/', import.meta.url).pathname); - const SnowpackDev = suite('snowpack.dev'); -let runtime; +let runtime, cwd; SnowpackDev.before(async () => { +// Bug: Snowpack config is still loaded relative to the current working directory. + cwd = process.cwd(); + process.chdir(new URL('../examples/snowpack/', import.meta.url).pathname); + const astroConfig = await loadConfig(new URL('../examples/snowpack', import.meta.url).pathname); const logging = { @@ -23,10 +24,16 @@ SnowpackDev.before(async () => { dest: process.stderr, }; - runtime = await createRuntime(astroConfig, logging); + try { + runtime = await createRuntime(astroConfig, logging); + } catch(err) { + console.error(err); + throw err; + } }); SnowpackDev.after(async () => { + process.chdir(cwd); await runtime && runtime.shutdown(); });