Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 BUG: Solid integration swallows component errors server-side #3280

Closed
1 task done
nonphoto opened this issue May 3, 2022 · 1 comment · Fixed by #3282
Closed
1 task done

🐛 BUG: Solid integration swallows component errors server-side #3280

nonphoto opened this issue May 3, 2022 · 1 comment · Fixed by #3282
Assignees
@matthewp
Labels
- P4: important Violate documented behavior or significantly impacts performance (priority)

Comments

@nonphoto
Copy link
Contributor

nonphoto commented May 3, 2022

What version of astro are you using?

v1.0.0-beta.22

Are you using an SSR adapter? If so, which one?

N/A

What package manager are you using?

pnpm

What operating system are you using?

Mac

Describe the Bug

Error messages in Solid components are swallowed by server pre-rendering. This makes it difficult to debug solid components. In the example BrokenComponent throws a useful error message but it only "Unable to render BrokenComponent!" appears in the logs.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-8cnxwy-lzkgtf?file=src/pages/index.astro

Participation

  • I am willing to submit a pull request for this issue.
@nonphoto nonphoto mentioned this issue May 3, 2022
Merged
@matthewp matthewp self-assigned this May 10, 2022
@matthewp matthewp added - P4: important Violate documented behavior or significantly impacts performance (priority) s1-small labels May 10, 2022
@nonphoto
Copy link
Contributor Author

nonphoto commented May 17, 2022 •
edited
Loading

@matthewp Looks like this popped up again. At least I'm still seeing it in beta.29: https://stackblitz.com/edit/github-8cnxwy-f4fagu?file=package.json

Edit: Ignore the above, I forgot to update all packages. Here's a version that works: https://stackblitz.com/edit/github-8cnxwy-t4k5zb?file=package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewp matthewp

Labels
- P4: important Violate documented behavior or significantly impacts performance (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove try/catch from solid component check nonphoto/astro
3 participants
@matthewp @FredKSchott @nonphoto