Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 BUG: Werid behaviour with Astro.canonicalURL.pathname and Astro.canonicalURL.href with /1 route? #3058

Closed
1 task
Yofou opened this issue Apr 10, 2022 · 2 comments · Fixed by #3393 · May be fixed by ilovera-woolworthslimited/wow-bshop#2
Closed
1 task

🐛 BUG: Werid behaviour with Astro.canonicalURL.pathname and Astro.canonicalURL.href with /1 route? #3058

Yofou opened this issue Apr 10, 2022 · 2 comments · Fixed by #3393 · May be fixed by ilovera-woolworthslimited/wow-bshop#2
Assignees
@tony-sull
Labels
- P4: important Violate documented behavior or significantly impacts performance (priority)

Comments

@Yofou
Copy link

Yofou commented Apr 10, 2022

What version of astro are you using?

^1.0.0-beta.5

What package manager are you using?

npm

What operating system are you using?

Linux

Describe the Bug

Video of display the bug

2022-04-10.18-37-43.mp4

TLDW

So when having numerical id routes like /1, /2, /3 everything behaves as expected but /1 which for some reason
Astro.canonicalURL.pathname and Astro.canonicalURL.href as index page (/)

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-hadnau

Participation

  • I am willing to submit a pull request for this issue.
@Yofou Yofou changed the title 🐛 BUG: Werid behaviour with Astro.canonicalURL.pathname and Astro.canonicalURL.href 🐛 BUG: Werid behaviour with Astro.canonicalURL.pathname and Astro.canonicalURL.href with /1 route? Apr 10, 2022
@tony-sull tony-sull self-assigned this Apr 12, 2022
@tony-sull tony-sull mentioned this issue Apr 12, 2022
Closed
1 task
@tony-sull
Copy link
Contributor

Thanks for including a simple reproduction here!

Looks like we have a couple bugs related to numeric route params, picking this up now to see if we can knock out this and #3082 at the same time 👍

@tony-sull tony-sull linked a pull request Apr 12, 2022 that will close this issue
fix: paginate() didn't have the correct canonicalURL for page /1/ #3089
Closed
@tony-sull tony-sull added - P4: important Violate documented behavior or significantly impacts performance (priority) s1-small and removed bb:investigate labels May 10, 2022
@tony-sull
Copy link
Contributor

Confirmed this is still an issue in the latest beta release

I haven't tracked down where the routing inconsistency comes from yet, but we had an issue in non-SSR builds that was automatically removing /1 for paginated routes, may be related to this as well

@tony-sull tony-sull mentioned this issue May 17, 2022
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tony-sull tony-sull

Labels
- P4: important Violate documented behavior or significantly impacts performance (priority)
Projects
None yet
Milestone
No milestone
3 participants
@FredKSchott @tony-sull @Yofou