Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor 'account' tests #182

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danieleades
Copy link
Contributor

this PR is derived from #180 , but i think it makes sense as an incremental improvement.

this PR

  • deduplicates the setup logic in the 'account' tests
  • modifiers the mock query matchers to no longer depend on the ordering of the query parameters

The second one is the most important, since this was adding an unnecessary constraint on the implementation (and forcing you to use BTreeMaps despite not actually needing a sorted heap).

@danieleades
Copy link
Contributor Author

my intention is to roll this out to the other tests as well

@danieleades danieleades marked this pull request as ready for review October 28, 2022 04:18
@danieleades
Copy link
Contributor Author

i'll mark this a draft for now. I want to see how well this generalises to the other tests before committing to the approach

@danieleades danieleades marked this pull request as draft November 2, 2022 22:01
@danieleades danieleades marked this pull request as ready for review December 15, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant