Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting the application key in .env files when running key:generate #29

Closed
LukeTowers opened this issue Mar 12, 2021 · 7 comments

Comments

@LukeTowers LukeTowers added this to the v1.1.3 milestone Mar 12, 2021
@LukeTowers LukeTowers modified the milestones: v1.1.3, v1.1.4 Apr 17, 2021
@bennothommo bennothommo removed this from the v1.1.4 milestone May 21, 2021
@RomainMazB
Copy link
Contributor

Ping @ericp-mrel, maybe you'd like to reopen the PR you've made on OC to fix this?

@ericp-mrel
Copy link
Contributor

Yeah, I can re-create a PR since OctoberCMS rejected my changes.

@ericp-mrel
Copy link
Contributor

PRs have been created. Let me know if there's anything I need to do or could improve in the PRs.

@github-actions
Copy link

This issue will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this issue is still relevant or you would like to see it actioned, please respond and we will re-open this issue.
If this issue is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

@github-actions
Copy link

This issue will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this issue is still relevant or you would like to see it actioned, please respond and we will re-open this issue.
If this issue is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

@github-actions
Copy link

This issue will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this issue is still relevant or you would like to see it actioned, please respond and we will re-open this issue.
If this issue is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

@LukeTowers LukeTowers added this to the v1.1.8 milestone Jan 14, 2022
@LukeTowers LukeTowers modified the milestones: v1.1.8, v1.1.9 Feb 2, 2022
@LukeTowers LukeTowers modified the milestones: v1.1.9, v1.2.0 Feb 16, 2022
@LukeTowers
Copy link
Member Author

Going forward (1.2+) .env files will be first class citizens in Winter so we no longer wish to support setting the application key in the config file by default. If someone has a legitimate need for it we can re-evaluate in the future but as of wintercms/storm#40 the key:generate command is reverted back to mostly the Laravel default (exception is that it will generate a .env file if none exists).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants