You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// super effectiveness against movement types with sacred seal check and thani check
- if (attacker.weaponData.hasOwnProperty("move_effective") && defender.moveType.includes(attacker.weaponData.move_effective)) { + if ((attacker.weaponData.hasOwnProperty("move_effective2") && defender.moveType.includes(attacker.weaponData.move_effective2))||(attacker.weaponData.hasOwnProperty("move_effective") && defender.moveType.includes(attacker.weaponData.move_effective))) {
if (defender.passiveAData.hasOwnProperty("cancel_effective")) { if (defender.passiveAData.hasOwnProperty("cancel_effective")) {
battleInfo.logMsg += "Effectiveness against " + defender.moveType + " neutralized by opponent [" + skillInfo['a'][defender.passiveA].name + "]. "; battleInfo.logMsg += "Effectiveness against " + defender.moveType + " neutralized by opponent [" + skillInfo['a'][defender.passiveA].name + "]. ";
} else if (defender.sealData.hasOwnProperty("cancel_effective")){ } else if (defender.sealData.hasOwnProperty("cancel_effective")){
Ideally we don't have move_effective2 anymore, since this is more of the old style that has a lot of copy/pasted code. Gets hard to maintain.
Thanks to @Lorenzooone for implementing this in the first place! Minor gripe, and nothing we haven't seen before.
Cheers
The text was updated successfully, but these errors were encountered:
Code segment
Ideally we don't have move_effective2 anymore, since this is more of the old style that has a lot of copy/pasted code. Gets hard to maintain.
Thanks to @Lorenzooone for implementing this in the first place! Minor gripe, and nothing we haven't seen before.
Cheers
The text was updated successfully, but these errors were encountered: