feat(dynamodb): add billingMode, deletionProtection props #272
Conversation
|
thoroc
changed the title
thoroc
changed the title
Chriscbr
changed the title
| deletionProtectionEnabled: props.deletionProtection ?? false, | ||
| lifecycle: { | ||
| preventDestroy: props.deletionProtection ?? true |
There was a problem hiding this comment.
Should these fields default to the same value?
There was a problem hiding this comment.
Oh that's a good catch. Yes that would make sense. I actually was wondering if there has been a wider discussion about having a system wide sensible default for those things.
There was a problem hiding this comment.
I don't think there's any built-in mechanisms at the moment -- perhaps we can add deletionProtection as a prop for more resources and eventually establish it as a convention of some sort.
| let tableWithBillingModeProvisioned = new dynamodb.Table({ | ||
| billingMode: dynamodb_types.BillingMode.PROVISIONED, | ||
| attributes: [ | ||
| { name: "id", type: "S" }, | ||
| ], | ||
| hashKey: "id", | ||
| }); | ||
|
|
||
| let simClient = dynamodb_sim.Util.createClient({ | ||
| endpoint: "http:https://localhost:8000", | ||
| region: "us-west", | ||
| credentials: { | ||
| accessKeyId: "accessKeyId", | ||
| secretAccessKey: "secretAccessKey", | ||
| }, | ||
| }); | ||
|
|
||
| test "Sim: table with billing mode `provisioned`" { | ||
|
|
||
| let tableDescription = simClient.describeTable({ | ||
| TableName: tableWithBillingModeProvisioned.tableName, | ||
| }); | ||
|
|
||
| expect.equal( | ||
| tableDescription.billingMode, | ||
| dynamodb_types.BillingMode.PROVISIONED | ||
| ); | ||
| } |
There was a problem hiding this comment.
I think this test will fail if you try running it on the tf-aws platform since it's directly calling into the dynamodb_sim implementation. If we want to scope this test just to run on the simulator, you can wrap all of it in a block like:
bring util;
if util.env("WING_TARGET") == "sim" {
// resources...
// tests ...
}
Trying to address the missing properties coming from AWS CDK for DynamoDB Table.
Closes: #6753