Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add hifiberry device: "Failed to connect" #18

Closed
fjfricke opened this issue Apr 8, 2022 · 8 comments
Closed

Cannot add hifiberry device: "Failed to connect" #18

fjfricke opened this issue Apr 8, 2022 · 8 comments

Comments

@fjfricke
Copy link

fjfricke commented Apr 8, 2022

With the new version released, I can still not add a new integration. Getting this error:

`
Logger: homeassistant
Source: runner.py:96
First occurred: 13:31:24 (1 occurrences)
Last logged: 13:31:24

Error doing job: Unclosed client session
`

@fjfricke fjfricke changed the title Cannot add hifiberry Cannot add hifiberry device: "Failed to connect" Apr 8, 2022
@fjfricke
Copy link
Author

fjfricke commented Apr 8, 2022

I think it has something to do with my setup so I'll try to reinstall home assistant.

@fjfricke
Copy link
Author

fjfricke commented Apr 8, 2022

CAn't get it running.. Do you know how I can get more logs?

@malteger
Copy link
Contributor

malteger commented Apr 8, 2022

I think this is happening because of the switch to the socketio API. I have enabled it in the hifiberry device according to https://github.com/hifiberry/audiocontrol2/blob/master/doc/socketio_api.md and after that it was working again. It would be a good idea if the documentation could be updated.

@schnabel Am I correct that with your PR the old REST API is no longer supported?

@fjfricke
Copy link
Author

fjfricke commented Apr 8, 2022

perfect! That helped :)

@fjfricke fjfricke closed this as completed Apr 8, 2022
@schnabel
Copy link
Contributor

schnabel commented Apr 8, 2022

@malteger @fjfricke Sorry for the confusion. I am going to write some documentation! This story was a nightmare that went on for a few month because five different repositories were involved. Great that it finally works for you. Do you uses HACS? I hope @willholdoway can now start making it a HA core integration :-).

@malteger
Copy link
Contributor

malteger commented Apr 8, 2022

@schnabel No, I am using it by cloning the repository and copying files, with that I also see which changes have been done.

Nice work with the socketio implementation, a saw all the other PRs to get this working and remembered that the hifiberry maintainer was not going with having socketio enabled by default. I think this is a slight problem for people who have not so much technical knowledge, that is the reason I asked about the REST API, as that is enabled by default (I think, don't remember).

@schnabel
Copy link
Contributor

schnabel commented Apr 8, 2022

Yes, the REST API is always enabled. It might be a good idea to use it as fallback API here. @willholdoway what do you think? On the other hand, I will write the documentation tomorrow and whoever uses a this setup is probably able to follow the instructions.

@willholdoway
Copy link
Owner

Fallnback API tricky. I always like resilience but it's a very different product and while the fallback is in action we'll be getting all the old log bloating etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants