{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":6495919,"defaultBranch":"master","name":"mediawiki-tools-codesniffer","ownerLogin":"wikimedia","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2012-11-01T19:33:40.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/56668?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1706550263.0","currentOid":""},"activityList":{"items":[{"before":"bc3d6da32b933b75a0d93687139896c272e2e1a6","after":"a5856787c1e5b2a1366261c274834e8945ab8bbf","ref":"refs/heads/master","pushedAt":"2024-06-13T23:24:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"PhpunitAnnotationsSniff: Update also absolute class names in @covers\n\nChange-Id: Ibd0f48e14e799a046b73d1bb42c1991ebde757ae","shortMessageHtmlLink":"PhpunitAnnotationsSniff: Update also absolute class names in <a class=\"user-mention notranslate\" data-hovercard-type=\"organization\" data-hovercard-url=\"/orgs/Covers/hovercard\" data-octo-click=\"hovercard-link-click\" data-octo-dimensions=\"link_type:self\" href=\"https://github.com/Covers\">@Covers</a>"}},{"before":"0354b620e6d228d486a08443d18139005a7d8a62","after":"bc3d6da32b933b75a0d93687139896c272e2e1a6","ref":"refs/heads/master","pushedAt":"2024-05-17T18:56:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"ExtendClassUsageSniff: Add $wgInitialSessionId to non-config variables\n\nThis is not a config variable, we should not encourage using\n::getConfig()->get()\n\nSee change I80f7436 for example.\n\nChange-Id: I245e9cc4ff476c625c6482d903c73314c5cd74bb","shortMessageHtmlLink":"ExtendClassUsageSniff: Add $wgInitialSessionId to non-config variables"}},{"before":"53f2f8de144c3dec558d99e6f4931902a9c98e87","after":"0354b620e6d228d486a08443d18139005a7d8a62","ref":"refs/heads/master","pushedAt":"2024-05-04T16:38:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"Update minus-x to 1.1.3\n\nthis repo is a libup canary\n\nChange-Id: Ic89fd967fae36eb252a7635f209bbe30de0467e4","shortMessageHtmlLink":"Update minus-x to 1.1.3"}},{"before":"f70ed43bb17f69d50e9fdfab78a897a6ae4b9a24","after":"53f2f8de144c3dec558d99e6f4931902a9c98e87","ref":"refs/heads/master","pushedAt":"2024-04-21T10:56:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"build: Upgrade php-parallel-lint/php-parallel-lint to 1.4.0\n\nThis repo is a 'canary' for LibUp, and thus a blocker to all other\nrepos getting this; let's just manually fix it here\n\nChange-Id: Ia52925c60f3c2bc41a6e8a269aa28410290c8c5a","shortMessageHtmlLink":"build: Upgrade php-parallel-lint/php-parallel-lint to 1.4.0"}},{"before":"9906359c0be283b85c8cf90ac1bceff074ed805c","after":"f70ed43bb17f69d50e9fdfab78a897a6ae4b9a24","ref":"refs/heads/master","pushedAt":"2024-03-18T21:00:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"Handle multi-line anon class in SpaceBeforeClassBrace.BraceNotOnOwnLine\n\nThe open braces should be enforced relative to the parenthesis closer\nwhen looking at anon classes.\n\nBug: T347440\nChange-Id: I03f075a716a14770da09a4eff9fc6a819ac5eb59","shortMessageHtmlLink":"Handle multi-line anon class in SpaceBeforeClassBrace.BraceNotOnOwnLine"}},{"before":"ff182aebc730dafd8c2d4acc697616d9ad309a2b","after":"9906359c0be283b85c8cf90ac1bceff074ed805c","ref":"refs/heads/master","pushedAt":"2024-03-12T14:20:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"Replace hard-coded @…-import-type with more flexible config\n\nBug: T176885\nChange-Id: Icd7716a38fce6c3fc231a35415a2bf26cdd3f7c5","shortMessageHtmlLink":"Replace hard-coded @…-import-type with more flexible config"}},{"before":"ee9c3ba707447df65cefb38901fde1172b5cb2b1","after":"ff182aebc730dafd8c2d4acc697616d9ad309a2b","ref":"refs/heads/master","pushedAt":"2024-03-12T12:07:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"Don't report unused classes in @phpstan… and @psalm-import-type\n\nThere are multiple ways to solve this. This is just one suggestion.\nSee T176885.\n\nThis adds quite a bit of complexity to the code. But I think there is\nno way around this because the syntax of the tag is quite complex and\nunique. See\nhttps://phpstan.org/writing-php-code/phpdoc-types#local-type-aliases\nhttps://psalm.dev/docs/annotating_code/supported_annotations/#psalm-import-type\n\nBug: T176885\nChange-Id: Ia4d166b00653a722001d217d4327eb650c48a5f0","shortMessageHtmlLink":"Don't report unused classes in <a class=\"user-mention notranslate\" data-hovercard-type=\"organization\" data-hovercard-url=\"/orgs/phpstan/hovercard\" data-octo-click=\"hovercard-link-click\" data-octo-dimensions=\"link_type:self\" href=\"https://github.com/phpstan\">@phpstan</a>… and @psalm-import-type"}},{"before":"13c60eb650a497a6bafb9abb707c47f42340733d","after":"ee9c3ba707447df65cefb38901fde1172b5cb2b1","ref":"refs/heads/master","pushedAt":"2024-03-02T23:16:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"Add Generic.CodeAnalysis.RequireExplicitBooleanOperatorPrecedence\n\nAs explained in the task, this sniffs disallows mixing different boolean\noperators without parentheses to clarify their precedence.\n\nBug: T358966\nChange-Id: I456e0843c6d891d3d03afedc916a573046d3cb06","shortMessageHtmlLink":"Add Generic.CodeAnalysis.RequireExplicitBooleanOperatorPrecedence"}},{"before":"486f7fc235dca65269aa93bf2a16dcc748dd0756","after":"13c60eb650a497a6bafb9abb707c47f42340733d","ref":"refs/heads/master","pushedAt":"2024-03-02T23:16:26.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"Add Universal.PHP.LowercasePHPTag\n\nThis is a tiny sniff introduced in PHPCSExtra 1.2.0 that enforces\n`<?php` to be lowercase. It is an uncontroversial change that adheres\nwith our existing practices, but may be useful for new contributors.\n\nChange-Id: I2f94c2626898cd0e9c4f5da07a592a8661c6da5b","shortMessageHtmlLink":"Add Universal.PHP.LowercasePHPTag"}},{"before":"b3b32586576c934ad03fa886e150088f5e10eff0","after":"486f7fc235dca65269aa93bf2a16dcc748dd0756","ref":"refs/heads/master","pushedAt":"2024-03-02T23:01:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"build: Update codesniffer to 3.9.0, phpcsextra to 1.2.1\n\nNo major changes for PHPCSExtra.\n\nPHP_CodeSniffer has more changes, but none of them seem to be affecting\nus negatively. Most notably, linting JS and CSS files has been\ndeprecated, and the whole MySource standard as well. We aren't using\neither of them TTBOMK.\n\nChange-Id: Ib00fa247fd2f88a97e43c4344adc834dc487c54e","shortMessageHtmlLink":"build: Update codesniffer to 3.9.0, phpcsextra to 1.2.1"}},{"before":"40269a8125569caab804848dc99cc04add7f7840","after":"b3b32586576c934ad03fa886e150088f5e10eff0","ref":"refs/heads/master","pushedAt":"2024-02-06T03:01:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"build: Updating mediawiki/mediawiki-phan-config to 0.14.0\n\nChange-Id: Ie2099f81ce0c9db03dedd8bd576d24d80273150f","shortMessageHtmlLink":"build: Updating mediawiki/mediawiki-phan-config to 0.14.0"}},{"before":"62da540396e1ea648e5ae2f10dc9c0e24e2e20df","after":"40269a8125569caab804848dc99cc04add7f7840","ref":"refs/heads/master","pushedAt":"2024-02-02T16:23:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"build: Upgrade mediawiki/mediawiki-phan-config to 0.13.0\n\nChange-Id: I9929ec276d7bd879ef61dcc25f8b714936db109c","shortMessageHtmlLink":"build: Upgrade mediawiki/mediawiki-phan-config to 0.13.0"}},{"before":"501803b454e96c964e068c7f79f7ef1945662b08","after":"62da540396e1ea648e5ae2f10dc9c0e24e2e20df","ref":"refs/heads/master","pushedAt":"2024-01-30T21:00:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"build: Upgrade phpunit to 9.6.16\n\nBug: T342110\nChange-Id: I338d2e8ccc359401c61c182b17fcee7035a8d1fe","shortMessageHtmlLink":"build: Upgrade phpunit to 9.6.16"}},{"before":"c559bc02e87b0a969b6ed7380d7fa1d02738158b","after":"501803b454e96c964e068c7f79f7ef1945662b08","ref":"refs/heads/master","pushedAt":"2024-01-29T17:37:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"HISTORY: Start new section for (probably) v44.0.0\n\nChange-Id: I7a1b42ef46307b8d72066cd32fd1f4a8a88601c5","shortMessageHtmlLink":"HISTORY: Start new section for (probably) v44.0.0"}},{"before":"0ba59054880a670129d1ac6c59e63538806a8b27","after":"c559bc02e87b0a969b6ed7380d7fa1d02738158b","ref":"refs/heads/master","pushedAt":"2024-01-29T17:37:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"HISTORY: Mark this as v43.0.0\n\nBug: T353909\nChange-Id: I0e90c59d625b7cce57ba08cdd2806ba3376c3e45","shortMessageHtmlLink":"HISTORY: Mark this as v43.0.0"}},{"before":"6927784cf90c11ada8a8843ee30389e093480821","after":"0ba59054880a670129d1ac6c59e63538806a8b27","ref":"refs/heads/master","pushedAt":"2024-01-29T17:24:59.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"HISTORY: Add blended entry for 5351ea927 and 6927784cf\n\nChange-Id: If3835ec6f7cede7a1082200cf5eb431e9a0d8838","shortMessageHtmlLink":"HISTORY: Add blended entry for <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/wikimedia/mediawiki-tools-codesniffer/commit/5351ea927bc2256cb399b6a0698cda719d31cf45/hovercard\" href=\"https://github.com/wikimedia/mediawiki-tools-codesniffer/commit/5351ea927bc2256cb399b6a0698cda719d31cf45\"><tt>5351ea9</tt></a> and <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/wikimedia/mediawiki-tools-codesniffer/commit/6927784cf90c11ada8a8843ee30389e093480821/hovercard\" href=\"https://github.com/wikimedia/mediawiki-tools-codesniffer/commit/6927784cf90c11ada8a8843ee30389e093480821\"><tt>6927784</tt></a>"}},{"before":"8c9cb701e56226cac43fee2fa24b0d0e586f1733","after":"6927784cf90c11ada8a8843ee30389e093480821","ref":"refs/heads/master","pushedAt":"2024-01-27T00:55:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"build: Update squizlabs/php_codesniffer to 3.8.1\n\nhttps://github.com/PHPCSStandards/PHP_CodeSniffer/releases/tag/3.8.1\n\nAdjust expected texts in the tests as needed\n\nBug: T353926\nChange-Id: I2db52638d8acab4732cef8c668a044a79ab8cdee","shortMessageHtmlLink":"build: Update squizlabs/php_codesniffer to 3.8.1"}},{"before":"4861986b0710ea2c53b771fbcababa670b6ecd4d","after":"8c9cb701e56226cac43fee2fa24b0d0e586f1733","ref":"refs/heads/master","pushedAt":"2024-01-16T14:06:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"Enforce absolute class path for coverage annotations\n\nWe renamed many classes to be namespaced, but the @covers and\n@coversDefaultClass annotations weren't updated properly.\n\nThis relies on the use statement, so it would not complain about\nclass alias alone.\n\nAlso, disabled the noisy multiple-class warning for the test.\n\nBug: T183218\nChange-Id: I7e6dce5bf11ab454e9677bacb527ef601c394f14","shortMessageHtmlLink":"Enforce absolute class path for coverage annotations"}},{"before":"5351ea927bc2256cb399b6a0698cda719d31cf45","after":"4861986b0710ea2c53b771fbcababa670b6ecd4d","ref":"refs/heads/master","pushedAt":"2024-01-10T20:51:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"composer.json: Allow newer composer/semver\n\nChange-Id: Ic86a2ba66bd2b0428d57911cc9f5134a73cf4e6b","shortMessageHtmlLink":"composer.json: Allow newer composer/semver"}},{"before":"9640c32551c69c4dde8bf8e6d62da0a3d414a3ca","after":"5351ea927bc2256cb399b6a0698cda719d31cf45","ref":"refs/heads/master","pushedAt":"2024-01-10T19:24:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"build: Update squizlabs/php_codesniffer to 3.8.0\n\nhttps://github.com/PHPCSStandards/PHP_CodeSniffer/releases/tag/3.8.0\n\nAdjust expected texts in the tests as needed\n\nBug: T353926\nChange-Id: I7560eef9f2457bd497dcfaf15875baa860f9aabe","shortMessageHtmlLink":"build: Update squizlabs/php_codesniffer to 3.8.0"}},{"before":"8b4eb6564c37986410bbcf76212a499ecc7cf25b","after":"9640c32551c69c4dde8bf8e6d62da0a3d414a3ca","ref":"refs/heads/master","pushedAt":"2024-01-07T11:08:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"Deprecate $wgCommandLineMode\n\nBug: T313841\nChange-Id: I67172b6a98c83b9778039cd5dba518693e586508","shortMessageHtmlLink":"Deprecate $wgCommandLineMode"}},{"before":"b2eb92edbfe0119e4c3af9e179b46fa4cb0a1884","after":"8b4eb6564c37986410bbcf76212a499ecc7cf25b","ref":"refs/heads/master","pushedAt":"2024-01-02T14:06:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"LowerCamelFunctionsNameSniff: Ignore hook methods\n\nFor function names that have an underscore, check if the class\nimplements a hook interface associated with that method, using\nthe logic that a hook `on(Something)` comes from a hook interface\nnamed `(Something)Hook`\n\nBug: T273482\nChange-Id: I4c5d7fe7a533a2de885a5d9e6d3fb2a3470ea924","shortMessageHtmlLink":"LowerCamelFunctionsNameSniff: Ignore hook methods"}},{"before":"db9563150dbbc95f49b16a5f7e64c25a15f77a0c","after":"b2eb92edbfe0119e4c3af9e179b46fa4cb0a1884","ref":"refs/heads/master","pushedAt":"2023-11-20T03:01:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"Follow-up c12564765 & db9563150: Add blended HISTORY.md entry\n\nBug: T169189\nChange-Id: Iaeb0fc968ab13784b4caecf6febb41c111967bc9","shortMessageHtmlLink":"Follow-up <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/wikimedia/mediawiki-tools-codesniffer/commit/c12564765b690d5568376312c9b271e8b7a406af/hovercard\" href=\"https://github.com/wikimedia/mediawiki-tools-codesniffer/commit/c12564765b690d5568376312c9b271e8b7a406af\"><tt>c125647</tt></a> &amp; <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/wikimedia/mediawiki-tools-codesniffer/commit/db9563150dbbc95f49b16a5f7e64c25a15f77a0c/hovercard\" href=\"https://github.com/wikimedia/mediawiki-tools-codesniffer/commit/db9563150dbbc95f49b16a5f7e64c25a15f77a0c\"><tt>db95631</tt></a>: Add blended HISTORY.md entry"}},{"before":"5dcc9c1738207527325310a0aa0e3cd605faa07c","after":"db9563150dbbc95f49b16a5f7e64c25a15f77a0c","ref":"refs/heads/master","pushedAt":"2023-11-18T16:25:34.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"Increase --parallel to 64\n\nBug: T169189\nChange-Id: Ied3664de5bc793ae071337f4e25a5c4f9f948794","shortMessageHtmlLink":"Increase --parallel to 64"}},{"before":"c418d9f32836e4bc119162045076473405dc76d7","after":"5dcc9c1738207527325310a0aa0e3cd605faa07c","ref":"refs/heads/master","pushedAt":"2023-11-02T19:40:14.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"Follow-up c418d9f32: Add HISTORY.md entry\n\nChange-Id: I96f74b62891b1f8581eaa1ba2d697e9b089c0c08","shortMessageHtmlLink":"Follow-up <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/wikimedia/mediawiki-tools-codesniffer/commit/c418d9f32836e4bc119162045076473405dc76d7/hovercard\" href=\"https://github.com/wikimedia/mediawiki-tools-codesniffer/commit/c418d9f32836e4bc119162045076473405dc76d7\"><tt>c418d9f</tt></a>: Add HISTORY.md entry"}},{"before":"c2f2b1282de0f2e9b453e882d5312cd856b24c97","after":"c418d9f32836e4bc119162045076473405dc76d7","ref":"refs/heads/master","pushedAt":"2023-10-24T13:52:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"Allow @phan-side-effect-free annotation\n\nNeeded for I610435f4cbf7335605a6713758d15f8722478b72\n\nChange-Id: I9157b5d4fcff2f082f288c60887860ba27844d0d","shortMessageHtmlLink":"Allow @phan-side-effect-free annotation"}},{"before":"3e4be7c211614c0a911690166a153d505966e9cb","after":"c2f2b1282de0f2e9b453e882d5312cd856b24c97","ref":"refs/heads/master","pushedAt":"2023-10-22T02:00:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"Add test for awfully inconsistent code\n\nI've asked ChatGPT to generate a snippet of highly inconsistent PHP\ncode. Then I made it even worse. This should give us a test with some\nextreme edge cases to see what our PHPCS standards do or do not catch.\n\nFor this test, the .fixed result is particularly interesting, as it\nshows what PHPCS would consider correct after a pass of phpcbf. This can\nbe compared to what a human would deem to be correctly-formatted code.\n\nChange-Id: Ifd4661bf5e722aa500140b6a4651481dc342116a","shortMessageHtmlLink":"Add test for awfully inconsistent code"}},{"before":"584f389577492a41cf91688545196da9cf787d2b","after":"3e4be7c211614c0a911690166a153d505966e9cb","ref":"refs/heads/master","pushedAt":"2023-10-20T21:54:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"Replace AlternativeSyntaxSniff with upstream sniff\n\nIt does the same thing, but it is more thorough in that it actually\nreports an issue on every line where the alternative syntax is used (not\njust the closing keyword), and it offers an autofixer.\n\nRetain the existing test to make sure that the MW standard as a whole\nforbids alternative syntax.\n\nBug: T349327\nChange-Id: I404cf2ebfc30c71e6c3d3ad7d40265828901abf7","shortMessageHtmlLink":"Replace AlternativeSyntaxSniff with upstream sniff"}},{"before":"c3c66f9bc7790a53adbee318404e5a1949d91bc4","after":"584f389577492a41cf91688545196da9cf787d2b","ref":"refs/heads/master","pushedAt":"2023-10-20T21:53:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"Replace ShortListSyntaxSniff with upstream sniff\n\nThey are 100% identical.\n\nBug: T349327\nChange-Id: Ibf655b170b4c1ed9b712fc082b5926d56b5016b7","shortMessageHtmlLink":"Replace ShortListSyntaxSniff with upstream sniff"}},{"before":"db786d224aad3174f4121a64e228fd57074397a7","after":"c3c66f9bc7790a53adbee318404e5a1949d91bc4","ref":"refs/heads/master","pushedAt":"2023-10-20T21:52:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wmfgerrit","name":"Wikimedia Gerrit","path":"/wmfgerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2539292?s=80&v=4"},"commit":{"message":"Enable the `Universal.WhiteSpace.CommaSpacing` sniff\n\nThis sniff enforces the correct spacing around commas (no space before,\nand exactly one space or a newline after). The sniff provides an\nautofixer.\n\nIt currently emits 148 warnings in MW core, and most of them seem to be\ncorrect. The main exceptions are in-line comments where the author\nwanted to achieve vertical alignment of comments, like this:\n\n  [\n\t'foo',    # Some comment here\n\t'foobar', # Another comment here\n\t'x',      # And another here\n  ]\n\nThis mostly occurs in PHPUnit data providers. However:\n- Our coding conventions explicitly forbid vertical alignment: https://www.mediawiki.org/wiki/Manual:Coding_conventions#Vertical_alignment\n- The MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment,\n  enabled by default, forbids inline comments (it's disabled in lots of\n  places, though)\n- In some of the examples I found (~1/3), vertical alignment is already\n  broken, I guess because somebody changed some of the lines without\n  re-aligning everything (vertical alignment is forbidden for a\n  reason...).\n\nTherefore, I would considere the code in question to be non-compliant,\nand flagging it seems the right thing to do.\n\nThis new sniffs generalizes the existing OneSpaceInlineArray, which can\ntherefore be removed.\n\nBug: T349327\nBug: T347438\nChange-Id: Iccd11bfae43990228a803ef75d40544edd53bfeb","shortMessageHtmlLink":"Enable the <code>Universal.WhiteSpace.CommaSpacing</code> sniff"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEZO1-pQA","startCursor":null,"endCursor":null}},"title":"Activity · wikimedia/mediawiki-tools-codesniffer"}