Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matches not Parseing in the correct order #5

Closed
Techno11 opened this issue Jan 12, 2018 · 6 comments
Closed

Matches not Parseing in the correct order #5

Techno11 opened this issue Jan 12, 2018 · 6 comments

Comments

@Techno11
Copy link
Contributor

The matches are being parsed in the wrong order, Match 2 is parsed right after Match 19, 3 after Match 29, so the parsed matches apear in the order:

1-19, 2, 20-29, 3, 30-39, 4, 40-49, 50, etc...

If possible please fix. Thanks!

@Techno11 Techno11 changed the title Matches not Parseing Matches in order Matches not Parseing in the correct order Jan 12, 2018
@Techno11
Copy link
Contributor Author

Also, if quarterfinal/semifinal/final matches could follow the last qualifacation mach rather then be before match one, that would be great as well. Thanks!

@widavies
Copy link
Owner

Did you fix this in your pull request or is it still an issue?

@Techno11
Copy link
Contributor Author

Techno11 commented Jan 13, 2018

No. It is still an issue

@Techno11
Copy link
Contributor Author

Not Fixed in PR #7

@widavies
Copy link
Owner

Hey, just wanted to let you know I'll fix both of these issues within about a week, I'm currently busy finishing off some scouting software, but I'll have this repository up and running soon. Thanks!

@widavies
Copy link
Owner

widavies commented Jan 24, 2018

Alright, this issue is fixed and added to the release at: v1.0.1. If you don't want to update the library, you can easily sort like so:

   TBA.setAuthToken("");
   SMatch[] matches = new TBA().getMatches("2017mndu2");
   Collections.sort(Arrays.asList(matches));
   for(SMatch m : matches) {
        System.out.println(m.getMatchNumber());
   }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants