Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new fetch/4 signature to handle fallbacks #130

Merged
merged 6 commits into from
Nov 7, 2017
Merged

Conversation

whitfin
Copy link
Owner

@whitfin whitfin commented Nov 4, 2017

This fixes #126.

This will add a new fetch/4 function which has an explicit fallback argument, rather than dealing with options in the get/3 signature. This will temporarily remove default fallbacks on a cache state until they can be re-introduced after #132 is concluded.

@whitfin whitfin added this to the v3.0.0 milestone Nov 4, 2017
@whitfin whitfin self-assigned this Nov 4, 2017
@coveralls
Copy link

coveralls commented Nov 4, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling aa50943 on issue-126 into 06f68a5 on master.

@coveralls
Copy link

coveralls commented Nov 4, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling caa5608 on issue-126 into 06f68a5 on master.

@coveralls
Copy link

coveralls commented Nov 6, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 69572df on issue-126 into 06f68a5 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 69572df on issue-126 into 06f68a5 on master.

@coveralls
Copy link

coveralls commented Nov 7, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 72ae7c1 on issue-126 into 06f68a5 on master.

@coveralls
Copy link

coveralls commented Nov 7, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 1b95863 on issue-126 into 06f68a5 on master.

@whitfin whitfin merged commit 74d29bd into master Nov 7, 2017
@whitfin whitfin deleted the issue-126 branch November 7, 2017 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate fallbacks to live in a new fetch/4 function
2 participants