Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Hooks to live as GenServer and not GenEvent #71

Closed
whitfin opened this issue Sep 12, 2016 · 1 comment · Fixed by #77
Closed

Migrate Hooks to live as GenServer and not GenEvent #71

whitfin opened this issue Sep 12, 2016 · 1 comment · Fixed by #77
Assignees
@whitfin
Labels
enhancement
Milestone
v2.0.0

Comments

@whitfin
Copy link
Owner

whitfin commented Sep 12, 2016

GenEvent really doesn't do much for us here, the Hooks operate more as GenServers. There's a fair bit of bloat to Hook setup because of this, so we should just fallback to using GenServer. In future, perhaps GenStage but servers will suffice for now.

We should be able to keep the same interface, but this is going in v2 just in case.
@whitfin whitfin added this to the v2.0.0 milestone Sep 12, 2016
@whitfin whitfin self-assigned this Sep 12, 2016
@whitfin
Copy link
Owner Author

whitfin commented Sep 19, 2016

Also decided that results should always be provided and there should no longer be an option. If there's a pre hook, it's just provided with nil. Post hooks will always receive the action result. Removes the special casing and option.

@whitfin whitfin mentioned this issue Sep 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whitfin whitfin

Labels
enhancement
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

Migrate from GenEvent -> GenServer whitfin/cachex
1 participant
@whitfin