-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warmer blocking should be enabled on cache, rather than individual warmers #333
Comments
Perhaps |
I think I changed my mind here, because the naming is a little awkward. I think keeping the flag on the warmer itself does actually make sense - but i think that renaming it to something like If the |
RIght now whether a warmer is blocking on startup or not is defined in the actual warmer itself. This is misleading, because if you then use
Cachex.warm/2
, you're able to warm it in the opposite way (ignoring the definition).The way to approach this is to change the signature of
warmers
in the cache record to look something like this:Having them named and organized in this way makes the warmer definition clearer, and makes it clear that it can be overridden per warmer. I don't like the names above, but they're WIP until I come up with something better.
This is obviously a breaking change and as such will be included in 4.0.
The text was updated successfully, but these errors were encountered: