Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The :transactional option should be renamed to :transactions #335

Closed
whitfin opened this issue Mar 22, 2024 · 0 comments · Fixed by #339
Closed

The :transactional option should be renamed to :transactions #335

whitfin opened this issue Mar 22, 2024 · 0 comments · Fixed by #339
Assignees
@whitfin
Labels
enhancement
Milestone
v4.0.0

Comments

@whitfin
Copy link
Owner

whitfin commented Mar 22, 2024

Super low hanging fruit that I've left around for (literally) years. The name :transactional doesn't really fit with the rest of the options, so :transactions is much better. It's a breaking change so I was waiting for the next major to have some substance before filing this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whitfin whitfin

Labels
enhancement
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging a pull request may close this issue.

Rename transactional to transactions in options structs whitfin/cachex
1 participant
@whitfin