Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Let internalResponse be response's internal res..." #171

Closed
Ms2ger opened this issue Dec 9, 2015 · 2 comments
Closed

"Let internalResponse be response's internal res..." #171

Ms2ger opened this issue Dec 9, 2015 · 2 comments

Comments

@Ms2ger
Copy link
Member

Ms2ger commented Dec 9, 2015

https://fetch.spec.whatwg.org/#main-fetch

Let internalResponse be response's internal response.

In the case of a network error, there is no "internal response".
@annevk
Copy link
Member

annevk commented Dec 9, 2015

So I think it might be time to rethink this filter concept and see if there's a simpler way out. It was great when there was not much poking into the bits, but now that there is, a somewhat less error prone "API" seems warranted.

@annevk annevk closed this as completed in 200e745 Jan 8, 2016
@annevk
Copy link
Member

annevk commented Jan 8, 2016

I decided against rethinking it entirely. Would have a lot of consequences. If anyone wants to volunteer though, they would be welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ms2ger @annevk