Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the current realm for Response's static methods #1649

Merged
merged 2 commits into from
May 8, 2023

Conversation

annevk
Copy link
Member

@annevk annevk commented May 4, 2023

Fixes #1603.

cc @Ms2ger


Preview | Diff

@annevk annevk requested a review from domenic May 4, 2023 07:51
@domenic
Copy link
Member

domenic commented May 8, 2023

Right, so, ECMAScript only defines current Realm Record. (Or maybe even the current Realm Record?) In HTML we settled on "current realm" as our preferred alias to it, but HTML doesn't use Bikeshed so we didn't run into this build failure.

We could add an anchors block here, or maybe in the generic WHATWG boilerplate, or maybe we should get the generic ECMAScript -> WebRef database updated to add such an alias.

@annevk
Copy link
Member Author

annevk commented May 8, 2023

It seems there's quite a bit of ECMAScript references to untangle so I'm gonna leave that for later.

@annevk annevk merged commit 13cb7c9 into main May 8, 2023
1 check passed
@annevk annevk deleted the annevk/response-statics branch May 8, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Response static methods use null this value to specify the realm
2 participants