Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: @wagmi/cli optimize typescript judgment #3723

Merged
merged 3 commits into from
Mar 27, 2024
Merged

Conversation

leecobaby
Copy link
Contributor

Description

fix #3721
Optimized for monorepo and special directory structured projects, the user can specify the type of project.

Additional Information

Added an option for config

Example

import { defineConfig } from '@wagmi/cli'

export default defineConfig({
  out: 'src/generated.ts',
  isTypeScript: true,  // new
  contracts: [],
  plugins: [],
})

Before submitting this issue, please make sure you do the following.

  • Read the contributing guide
  • Added documentation related to the changes made.
  • Added or updated tests (and snapshots) related to the changes made.

Copy link

changeset-bot bot commented Mar 19, 2024

🦋 Changeset detected

Latest commit: 664c0a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@wagmi/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wagmi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 3:03pm

Copy link
Member

@tmm tmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's start with adding some more known tsConfig file names, and can add an explicit flag if necessary. Also, worth noting that if you use a *.ts Wagmi CLI config file, like wagmi.config.ts, then you are also opted in.

@tmm tmm merged commit d6bc98c into wevm:main Mar 27, 2024
14 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The generated.js gen by @wagmi/cli has an address type error
2 participants