Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CARD_OPENED_WEBHOOK_ENABLED=false not working #2666

Closed
rmsmgaspar opened this issue Aug 30, 2019 · 7 comments
Closed

CARD_OPENED_WEBHOOK_ENABLED=false not working #2666

rmsmgaspar opened this issue Aug 30, 2019 · 7 comments

Comments

@rmsmgaspar
Copy link

We are updating Wekan with the setting CARD_OPENED_WEBHOOK_ENABLED=false that cames by default but still we are receiving the webhook "CardSelected".
How can we disable this setting and not receive this notification.

Cheers,
RMSMG

@JASG94
Copy link

JASG94 commented Sep 3, 2019

Same problem here.

Currently using docker image v3.35 but found same problem in older versions (since v3.18 I think). Environment variable CARD_OPENED_WEBHOOK_ENABLED set to false and sending webhook notifications when a card is clicked on it.

Also tried not to set the variable (let it by default) and same problem. Also set to true the variable, same problem. Always a notification like "User CardSelected" is sent to webhook. It's a little bit annoying everytime a user click on a card to receive this notification.

Taking a look at the code I think that the error could be in client/components/cards/cardDetails.js in line 120:
if (Meteor.settings.public.CARD_OPENED_WEBHOOK_ENABLED)

I don't know why but it's like always this if statement has a true condition.

Thanks.

@rmsmgaspar
Copy link
Author

Any news about this issue?
Thanks

@xet7
Copy link
Member

xet7 commented Nov 4, 2019

@jymcheong @whowillcare

Can you look at this?

Related #2780

@xet7
Copy link
Member

xet7 commented Nov 4, 2019

Open webhook was originally added at Wekan v3.18 with this #2620

@jymcheong
Copy link

jymcheong commented Nov 5, 2019

@jymcheong @whowillcare

Can you look at this?

Related #2780

I commented out the block of code at line 120 onwards of CardDetails.js, did a docker-compose down then docker-compose up -d. It is still calling outgoingWebhooks.

@jymcheong
Copy link

jymcheong commented Nov 5, 2019

I used v3.49, started with Meteor directly without docker, no webhook event emitted when clicked.

@JASG94
Copy link

JASG94 commented Feb 12, 2020

In version 3.77 running on docker the problem is present again, when CARD_OPENED_WEBHOOK_ENABLED=false the alerts of CardSelected are sent anyway

@xet7 xet7 closed this as completed in 178f376 Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants