New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

使用了sketch measure的代码，虽然是MIT，也要声明一下吧 #7

Closed

sluke opened this issue Jul 4, 2017 · 3 comments

sluke commented Jul 4, 2017 •

edited

Loading

https://github.com/weixin/WeSketch/blob/50893144c8d5e533ac4ee5af786edfc273469124/WeSketch.sketchplugin/Contents/Sketch/common.js

https://github.com/utom/sketch-measure/blob/master/Sketch%20Measure.sketchplugin/Contents/Sketch/library/common.js

Contributor

RayPS commented Jul 4, 2017

具体是第几行到第几行？用 filemerge diff 了一下貌似并没有啊。

Author

sluke commented Jul 4, 2017

https://github.com/weixin/WeSketch/blob/50893144c8d5e533ac4ee5af786edfc273469124/WeSketch.sketchplugin/Contents/Sketch/common.js#L257-L426

https://github.com/utom/sketch-measure/blob/master/Sketch%20Measure.sketchplugin/Contents/Sketch/library/common.js#L1083-L1259

Collaborator

bugluo commented Jul 4, 2017 •

edited

Loading

十分感谢提醒，在 common.js 里面借鉴不少 measure 的代码，主要是 measure 开一个 webview 与之通讯�，已经加上引用。

bugluo closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment