Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alloption to entity:bundle-class #77

Closed
weitzman opened this issue Jan 12, 2022 · 3 comments · Fixed by #79
Closed

Add Alloption to entity:bundle-class #77

weitzman opened this issue Jan 12, 2022 · 3 comments · Fixed by #79

Comments

@weitzman
Copy link
Contributor

On www.mass.gov we have 35 node types (see below). I really dont want to type 1-35 separated by commas, nor do I want to run this command many many times. How about an All option at the top of the list?

Bundles, comma separated:
  [ 1] Right-rail (prototype)
  [ 2] Advisory
  [ 3] Alert (Page-level and Organization)
  [ 4] Binder
  [ 5] Promotional page
  [ 6] Contact Information
  [ 7] Curated List
  [ 8] Decision
  [ 9] Decision Tree
  [10] Decision Tree Branch
  [11] Decision Tree Conclusion
  [12] Error
  [13] Event
  [14] Executive Order
  [15] External data resource
  [16] Fee
  [17] Form
  [18] Guide
  [19] How-to
  [20] Information Details
  [21] Interstitial
  [22] Location
  [23] Location Detail
  [24] News
  [25] Organization
  [26] Basic page (prototype)
  [27] Person
  [28] Regulation
  [29] Rules of Court
  [30] Service Details
  [31] Service
  [32] Alert (Sitewide)
  [33] Stacked layout (prototype)
  [34] Topic Page
  [35] Utility Drawer

Also, we forgot to make an alias for entity:bundle-class. The command listing looks inconsistent without it.

@Chi-teck
Copy link
Owner

Also, we forgot to make an alias for entity:bundle-class. The command listing looks inconsistent without it.

We did not. Not sure why it's not listed in Drush.
https://github.com/Chi-teck/drupal-code-generator/blob/2.3.2/src/Command/Entity/EntityBundleClass.php#L25

@Chi-teck
Copy link
Owner

Chi-teck commented Jan 13, 2022

Given that it's a multiselect choice the user may enter something like "All, Article, Page" which a bit confusing.

@weitzman
Copy link
Contributor Author

weitzman commented Jan 13, 2022

When that happens we stop with a validation error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants