From 7813f8e9c9ef2393b80ff6c87f88cecea0e66d90 Mon Sep 17 00:00:00 2001 From: Andrea Righi Date: Tue, 20 Nov 2018 17:54:46 +0100 Subject: [PATCH] offwaketime: properly format "[Missed User Stack]" with folded output (#2051) In folded output format when both kernel and user stacks are missing, the message "[Missing User Stack]" is formatted incorrectly, for example: chrome;entry_SYSCALL_64_after_hwframe;do_syscall_64;SyS_poll;do_sys_poll;poll_schedule_timeout;schedule_hrtimeout_range;schedule_hrtimeout_range_clock;schedule;--;[Missed Kernel Stack];[;M;i;s;s;e;d; ;U;s;e;r; ;S;t;a;c;k;];fio 4955989 This is because we're incorrectly appending the missing stack message in the list of stack entries. Fix by appending the message as a single item. Signed-off-by: Andrea Righi --- tools/offwaketime.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/offwaketime.py b/tools/offwaketime.py index 0e4f35e0e43a..38a9ff25282b 100755 --- a/tools/offwaketime.py +++ b/tools/offwaketime.py @@ -342,7 +342,7 @@ def signal_ignore(signal, frame): if not args.kernel_stacks_only: line.extend(["-"] if (need_delimiter and k.w_u_stack_id > 0 and k.w_k_stack_id > 0) else []) if stack_id_err(k.w_u_stack_id): - line.extend("[Missed User Stack]") + line.append("[Missed User Stack]") else: line.extend([b.sym(addr, k.w_tgid) for addr in reversed(list(waker_user_stack))])