Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add runtime field of jest config #639

Closed
wants to merge 1 commit into from

Conversation

decadef20
Copy link

fix #603

@webpro
Copy link
Collaborator

webpro commented May 15, 2024

Thanks! Could you please add something to the related fixture so we'll have some coverage?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file shouldn't be added

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I also asked for #639 (comment) - any chance you could work that in as well?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've missed this comment. Sure, I'll do it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you've forgot to add the file? It doesn't seem to be in this branch yet.

@@ -26,4 +26,5 @@ module.exports = {
],
testResultsProcessor: 'jest-phabricator',
snapshotResolver: '<rootDir>/snapshotResolver.js',
runtime: '@side/jest-runtime',
};
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@webpro
Copy link
Collaborator

webpro commented May 26, 2024

There seems to be a failing test, any chance you could look into it?

@webpro webpro force-pushed the main branch 3 times, most recently from 13ba313 to 28f05f0 Compare June 8, 2024 12:09
@webpro
Copy link
Collaborator

webpro commented Jun 15, 2024

Is there still interest in wrapping up this pull request?

@webpro webpro force-pushed the main branch 2 times, most recently from d692d08 to 7aa2f6d Compare June 19, 2024 10:56
@webpro
Copy link
Collaborator

webpro commented Jul 21, 2024

Closing due to inactivity.

@webpro webpro closed this Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for dev dependency listed in jest config
3 participants