Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed pull requests #27

Open
jpreese opened this issue Aug 21, 2020 · 3 comments
Open

Closed pull requests #27

jpreese opened this issue Aug 21, 2020 · 3 comments
Labels
waiting for feedback The issue is waiting for additional feedback

Comments

@jpreese
Copy link

jpreese commented Aug 21, 2020

It looks like the pull request collector is hard coded to only pull back active pull requests. Any objection to also including closed? Would be useful to be able to capture how many pull requests have been completed, time to complete, etc.

@mblaschke
Copy link
Member

The goal is only to get opened PRs (eg. display them in grafana).
Otherweise the exporter would pull the hole database inside Prometheus which he should not do it.

Statistics would be another goal.

@mblaschke mblaschke added the waiting for feedback The issue is waiting for additional feedback label Aug 9, 2021
@andrew-gropyus
Copy link

I will chime in here if it is ok. One thing I am interested in getting visibility on is how long it takes a commit to go from 'git push' to deployed on a production system, a lead time essentially.

Tracking this per commit might be a bit much, so I think pull requests are a nice alternative. Being able to know how long a PR was open before being merged would help me in this calculation. I would be able to do something like 'avg time to close PR + avg build duration'.

Another approach might be to track just the PR creation times, and somehow carry the PR info into the build info metric. Then I also look at build_completed_time - pr_created_time.

@mblaschke
Copy link
Member

will have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for feedback The issue is waiting for additional feedback
Projects
None yet
Development

No branches or pull requests

3 participants