-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
viewportSpeedFactor multiplier become too small by large zoomlevel #3
Comments
Hi, the power base of |
hi @zakjan is there a workaround that you know of? Can you detail a bit more the work that would be needed to enable higher zoom levels? |
There is fp64 support in deck.gl, I need to explore it more in detail. https://deck.gl/docs/developer-guide/64-bits An alternative approach is to store particles in a coordinate space independent on zoom level. However, one of my goals for this library is to support user interaction with the viewport (zoom, pan). Storing particles in viewport coordinates assumes that the viewport is static, therefore any interaction forces that the particle state has to be reset. I'd like to avoid such resetting if possible. |
This is interesting:
https://deck.gl/docs/api-reference/extensions/fp64-extension I need to look into |
and here
|
Yeah, these points exactly. Could you let me know more about your usecase for larger zoom levels? I might be able to prioritize it. |
@zakjan does it make sense to you, knowing what you do about the plugin, that the issue of precision could be mitigated by using an image with a greater resolution? wondering if our image we created might get us around this issue. we can share that image with you as well if that would be helpful in debugging. I'm on @saintsjd team btw. |
de-activating the layer at zoom levels < 17, assuming it is accurate, would work for our purposes. |
@maxwell-oroark Yes please, it would be a great help if you can share the image for investigation. Either here or over e-mail. I'm not sure how the resolution itself could fix the issue, possibly there is more to that. |
I'll share via email. Sending it your way |
https://github.com/kamzek/deck.gl-particle/blob/7b8a656169cd77f269271ef3d8718ecf327438f0/src/particle-layer.js#L179
This code works well in ordinary zoomlevels, but larger zoomlevel means viewportSpeedFactor exponentially become zero.
Because of this, particles don't move beautifully in such small scale...
I tried some values and found good multiplier
1.7
intead of2
. This value makes move of particles better in small scale. The best number may be different in cases.So, in my opinion, the multiplier should be user-editable value as one of options -
zoomFactor
, what do you think?The text was updated successfully, but these errors were encountered: