Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile fail on ast<17 because of missing ast_log_ap #111

Closed
wdoekes opened this issue Aug 24, 2020 · 4 comments
Closed

Compile fail on ast<17 because of missing ast_log_ap #111

wdoekes opened this issue Aug 24, 2020 · 4 comments

Comments

@wdoekes
Copy link
Owner

wdoekes commented Aug 24, 2020

4652c90#commitcomment-41706256:

If I read this commit correctly here asterisk/asterisk@e4cf513 then ast_log_ap does not exist until Asterisk 17. Module cannot be loaded with this code on Asterisk 13.

https://c-faq.com/varargs/handoff.html

Looks like we should sprintf and pass a single argument instead..

@sergei-mironov
Copy link

sergei-mironov commented Aug 26, 2020

Same conclusion here. I'm using Asterisk 15.7. Please, fix!

@wdoekes
Copy link
Owner Author

wdoekes commented Aug 27, 2020

Same conclusion here. I'm using Asterisk 15.7. Please, fix!

Wrong tab, you should be in the "Pull requests" tab 😈

As this is a trivial issue, I'm sure you can manage that :)

@sergei-mironov
Copy link

Same conclusion here. I'm using Asterisk 15.7. Please, fix!

Wrong tab, you should be in the "Pull requests" tab

Umm, quick search through include/logger.h of asterisk15 doesn't reveal to me anything comparable to ast_log_as, so it looks like I'm in trouble here..

As this is a trivial issue, I'm sure you can manage that :)

My workaround is .. well .. I've managed to compile asterisk17

@wdoekes
Copy link
Owner Author

wdoekes commented Sep 2, 2020

Thanks @hardillb

@wdoekes wdoekes closed this as completed Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants