Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is much bigger than I imagined. There were quite a few things that changed because I moved the functionality for name parsing and construction more into
multicast-dns-service-types
, which this PR required to run (https://github.com/wesleytodd/multicast-dns-service-types/tree/v2.0.0).Also, while all of the tests pass, I had to change some of the values in them. They where all pretty much what looked like internal use only variables. Let me know if I am mistaken.
I haven't yet tested it with my little project, I will update this when I have, but I figured I would post it to get feedback first. I can also probably test out your ipp project to for compatibility (hopefully this wont break anything), but might not be able to for a few days.
Let me know what you think!