From 4738037fc9f5d0997e14d8e6f692c1a12764600e Mon Sep 17 00:00:00 2001 From: Jimmy Lucidarme Date: Fri, 6 May 2016 14:57:26 -0400 Subject: [PATCH 1/2] add rinfo to the service --- lib/browser.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/browser.js b/lib/browser.js index 00cc0ec..001db73 100644 --- a/lib/browser.js +++ b/lib/browser.js @@ -64,7 +64,7 @@ Browser.prototype.start = function () { var nameMap = {} if (!this._wildcard) nameMap[this._name] = true - this._onresponse = function (packet) { + this._onresponse = function (packet, rinfo) { if (self._wildcard) { packet.answers.forEach(function (answer) { if (answer.type !== 'PTR' || answer.name !== self._name || answer.name in nameMap) return @@ -76,7 +76,7 @@ Browser.prototype.start = function () { Object.keys(nameMap).forEach(function (name) { goodbyes(name, packet).forEach(self._removeService.bind(self)) - var matches = buildServicesFor(name, packet, self._txt) + var matches = buildServicesFor(name, packet, self._txt, rinfo) if (matches.length === 0) return matches.forEach(function (service) { @@ -132,7 +132,7 @@ function goodbyes (name, packet) { }) } -function buildServicesFor (name, packet, txt) { +function buildServicesFor (name, packet, txt, rinfo) { var records = packet.answers.concat(packet.additionals).filter(function (rr) { return rr.ttl > 0 // ignore goodbye messages }) @@ -158,6 +158,7 @@ function buildServicesFor (name, packet, txt) { service.name = name service.fqdn = rr.name service.host = rr.data.target + service.rinfo = rinfo service.port = rr.data.port service.type = types.name service.protocol = types.protocol From 18ce959ac249669cb983f4d70c1ef2536895c9c3 Mon Sep 17 00:00:00 2001 From: Jimmy Lucidarme Date: Fri, 6 May 2016 23:12:30 -0400 Subject: [PATCH 2/2] change rinfo variable name to mdnsRinfo --- lib/browser.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/browser.js b/lib/browser.js index 001db73..3cde7d0 100644 --- a/lib/browser.js +++ b/lib/browser.js @@ -64,7 +64,7 @@ Browser.prototype.start = function () { var nameMap = {} if (!this._wildcard) nameMap[this._name] = true - this._onresponse = function (packet, rinfo) { + this._onresponse = function (packet, mdnsRinfo) { if (self._wildcard) { packet.answers.forEach(function (answer) { if (answer.type !== 'PTR' || answer.name !== self._name || answer.name in nameMap) return @@ -76,7 +76,7 @@ Browser.prototype.start = function () { Object.keys(nameMap).forEach(function (name) { goodbyes(name, packet).forEach(self._removeService.bind(self)) - var matches = buildServicesFor(name, packet, self._txt, rinfo) + var matches = buildServicesFor(name, packet, self._txt, mdnsRinfo) if (matches.length === 0) return matches.forEach(function (service) { @@ -132,7 +132,7 @@ function goodbyes (name, packet) { }) } -function buildServicesFor (name, packet, txt, rinfo) { +function buildServicesFor (name, packet, txt, mdnsRinfo) { var records = packet.answers.concat(packet.additionals).filter(function (rr) { return rr.ttl > 0 // ignore goodbye messages }) @@ -158,7 +158,7 @@ function buildServicesFor (name, packet, txt, rinfo) { service.name = name service.fqdn = rr.name service.host = rr.data.target - service.rinfo = rinfo + service.mdnsRinfo = mdnsRinfo service.port = rr.data.port service.type = types.name service.protocol = types.protocol