Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

have id geohash as npm module #99

Closed
zoobot opened this issue Jan 13, 2022 · 3 comments · Fixed by #100
Closed

have id geohash as npm module #99

zoobot opened this issue Jan 13, 2022 · 3 comments · Fixed by #100
Assignees
@jazhen
Labels
backend frontend

Comments

@zoobot
Copy link
Member

zoobot commented Jan 13, 2022 •
edited
Loading

Has new repo
unique tree id based off geohash, sourceid, AND unique common name, scientific name, city?
@zoobot zoobot added the backend label Jan 20, 2022
@jazhen jazhen added frontend and removed frontend labels Feb 3, 2022
@zoobot zoobot changed the title have id geohash as microservice have id geohash as npm module May 26, 2022
@zoobot zoobot assigned jazhen and unassigned Jemoka and zbuster05 May 26, 2022
@zoobot
Copy link
Member Author

zoobot commented May 26, 2022

If you are going to test the db migrations wtt_db waterthetrees/wtt_front#29 with having a treetype or trees table for each species of tree, this may change the tree ids are created and also fix the bad tree naming issue: waterthetrees/wtt_front#237 . We may want to separate geohash and sourceid/city function from the common/scientific name part of the tree id.

@zoobot zoobot mentioned this issue May 26, 2022
Open
@jazhen
Copy link
Contributor

jazhen commented Jun 23, 2022

The id code has been moved to a npm package: https://www.npmjs.com/package/@waterthetrees/tree-id

@jazhen
Copy link
Contributor

jazhen commented Jun 23, 2022

I need to change the package type to "module", update the readme, and replace any calls to createIdForTree to use the library instead.

@jazhen jazhen transferred this issue from waterthetrees/wtt_front Jul 7, 2022
@jazhen jazhen linked a pull request Jul 7, 2022 that will close this issue
Replace local id creation with @waterthetrees/tree-id package #100
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jazhen jazhen

Labels
backend frontend
Projects
Water the Trees
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace local id creation with @waterthetrees/tree-id package waterthetrees/wtt_server
4 participants
@jazhen @zoobot @Jemoka @zbuster05