Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighthouse CI giving webpack errors with speed-measure-webpack-plugin #666

Open
zoobot opened this issue Apr 19, 2023 · 4 comments · Fixed by #669
Open

Lighthouse CI giving webpack errors with speed-measure-webpack-plugin #666

zoobot opened this issue Apr 19, 2023 · 4 comments · Fixed by #669
Assignees
Labels
help wanted Extra attention is needed

Comments

@zoobot
Copy link
Member

zoobot commented Apr 19, 2023

https://github.com/waterthetrees/wtt_front/actions/runs/4738740736/jobs/8412915864?pr=652

Tried to fix by changing this:
return ifAnalyze(new SpeedMeasurePlugin().wrap({ ...config }), config);
to this:
return ifAnalyze(new SpeedMeasurePlugin().wrap(config), config);

return ifAnalyze(new SpeedMeasurePlugin().wrap({ ...config }), config);

per this suggestion: stephencookdev/speed-measure-webpack-plugin#171

Possibly related things to look at:

stephencookdev/speed-measure-webpack-plugin#164

Might try this:

const smp = new SpeedMeasurePlugin();
module.exports = {
  webpack: smp.wrap({
    plugins: [
      //...
    ],
  }),
};

or just this:

const smp = new SpeedMeasurePlugin();
module.exports = {webpack: smp.wrap({plugins: config.plugins})};

stephencookdev/speed-measure-webpack-plugin#174

@zoobot zoobot added the help wanted Extra attention is needed label Apr 19, 2023
@zoobot
Copy link
Member Author

zoobot commented Apr 19, 2023

@PGrad just pinging you on here in case you've seen this before?
I've tried one fix that worked locally but not with Lighthouse CI.
Getting this warning after adding ReactRefreshWebpackPlugin.
Any ideas on this one?
I can work on it more later tomorrow.

@zoobot
Copy link
Member Author

zoobot commented Apr 20, 2023

Tried this and still getting the warning:

return ifAnalyze(
    new SpeedMeasurePlugin().wrap({ plugins: config.plugins }),
    config,
  );

@zoobot
Copy link
Member Author

zoobot commented Apr 25, 2023

hot-reload is no longer working and build is crashing on every change after recent lighthouse/storybook fix changes.

@PGrad
Copy link
Contributor

PGrad commented Apr 26, 2023

I'm not seeing issues with hot reload on main, let's discuss today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
Status: Help Wanted
Development

Successfully merging a pull request may close this issue.

2 participants