Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors using latest crystal #52

Closed
teodor-pripoae opened this issue May 31, 2016 · 10 comments
Closed

Errors using latest crystal #52

teodor-pripoae opened this issue May 31, 2016 · 10 comments

Comments

@teodor-pripoae
Copy link

I'm having a few errors when using latest crystal (0.17.4).


require "active_record"
^

in ./libs/active_record/active_record.cr:1: while requiring "./registry"

require "./registry"
^

in ./libs/active_record/registry.cr:1: while requiring "./adapter"

require "./adapter"
^

in ./libs/active_record/adapter.cr:1: while requiring "./types"

require "./types"
^

Syntax error in ./libs/active_record/types.cr:6: expecting token 'CONST', not '='

    {% as = "#{group.id}Types".id unless as %}
@Obversity
Copy link

Same here.

@waterlink
Copy link
Owner

@teodor-pripoae @Obversity I have released version 0.4.2, it should work with Crystal 0.18.4

@akitaonrails
Copy link
Contributor

akitaonrails commented Jul 11, 2016

I'm obviously doing something stupid and missing something but when I try to require version 0.4.2 in my shards.yml or even the master branch I keep getting this:

Error resolving active_record (*, 0.4.1)

I tried deleting both libs/ and .shards/ folder and the lock file and starting from scratch but it keeps failing with the same error above. Tips?

@waterlink
Copy link
Owner

Oh, there is a chance that the adapter has to be updated. Which one do you use?

@akitaonrails
Copy link
Contributor

Ahh, true, it's postgres_adapter and I am pointing to master as well.

@waterlink
Copy link
Owner

Maybe you could send a pull request to postgres adapter? I could help along the way and support you if you will have any questions about it :)

And open issue on respective repository would be awesome!

@akitaonrails
Copy link
Contributor

Of course, will do :-)

@akitaonrails
Copy link
Contributor

akitaonrails commented Jul 12, 2016

I think that with this PR and this PR to the pg adapter, they should work again.

@waterlink what do you think?

@fridgerator
Copy link

this seems to be resolved now?

@waterlink
Copy link
Owner

I think so :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants