Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Subtitles] Add Ability to Change Text Size #123

Closed
JulienDev opened this issue Aug 2, 2024 · 4 comments
Closed

[Subtitles] Add Ability to Change Text Size #123

JulienDev opened this issue Aug 2, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request libmdk mdk bug

Comments

@JulienDev
Copy link

Hello,

I tried to figure out how to change the subtitle text size, but I didn't find any way to do it. I also checked in libmdk, but it seems not supported. Could you please let me know how this can be achieved?

Thanks

@wang-bin
Copy link
Owner

wang-bin commented Aug 2, 2024

yes, not supported yet

@wang-bin wang-bin self-assigned this Aug 3, 2024
@wang-bin wang-bin added enhancement New feature or request libmdk mdk bug labels Aug 3, 2024
@wang-bin
Copy link
Owner

upgrade dependencies to support this feature, subtitle style can be set in registerWith https://github.com/wang-bin/mdk-sdk/wiki/Player-APIs#subtitle-properties

@JulienDev
Copy link
Author

Hey @wang-bin, I can confirm it's working, however when I update the size while the video is playing, the text size doesn't change and I need to close and reopen the player. Is there a way to force the player to render subtitles with the updated configuration?

@wang-bin
Copy link
Owner

wang-bin commented Nov 5, 2024

Upgrade dependency when this build is completed, then new style will be applied in the next frame

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request libmdk mdk bug
Projects
None yet
Development

No branches or pull requests

2 participants