Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ktransducer #437

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

faridyagubbayli
Copy link
Collaborator

Towards #436

Moved active_elements, transmit_apodization, receive_apodization and related methods to the kWaveTransducerSimple while ensuring backwards compatibility. This is part of the effort to refactor the ktransducer.py.

@faridyagubbayli
Copy link
Collaborator Author

@waltsims @djps can you have a look and comment on the direction? If the direction looks good, I'll go ahead and update the examples to use the new structure.

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 69.64286% with 17 lines in your changes missing coverage. Please review.

Project coverage is 71.90%. Comparing base (98b0d26) to head (18daf0a).

Files Patch % Lines
kwave/ktransducer.py 69.64% 14 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #437      +/-   ##
==========================================
+ Coverage   71.84%   71.90%   +0.05%     
==========================================
  Files          46       46              
  Lines        6744     6776      +32     
  Branches     1496     1503       +7     
==========================================
+ Hits         4845     4872      +27     
- Misses       1334     1337       +3     
- Partials      565      567       +2     
Flag Coverage Δ
3.10 72.10% <69.64%> (+0.05%) ⬆️
3.11 72.10% <69.64%> (+0.05%) ⬆️
3.12 72.10% <69.64%> (+0.05%) ⬆️
3.9 71.87% <69.64%> (+0.05%) ⬆️
macos-latest 71.84% <69.64%> (+0.05%) ⬆️
ubuntu-latest 71.87% <69.64%> (+0.05%) ⬆️
windows-latest 71.88% <69.64%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waltsims
Copy link
Owner

@faridyagubbayli how do you plan to make this backwards compatible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants