Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] The simulation option pml_auto=True does not seem to affect kSpaceFirstOrderAS #376

Open
waltsims opened this issue Apr 23, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@waltsims
Copy link
Owner

Describe the bug
When running an axis-symmetric simulation with the simulation option pml_auto=True, the following warning is still raised:

WARNING:root:Highest prime factors in each dimension are [  3 109]
WARNING:root:Use dimension sizes with lower prime factors to improve speed

To Reproduce
Steps to reproduce the behavior:

  1. Go to the at_focused_bowl_AS example and run the ipython notebook.
  2. Click on update the simulation arguments to
simulation_options = SimulationOptions(
    simulation_type=SimulationType.AXISYMMETRIC,
    data_cast='single',
    data_recast=False,
    save_to_disk=True,
    save_to_disk_exit=False,
    pml_inside=False,
    pml_auto=True)
  1. run the notebook
  2. See warning

Expected behavior
Expected behavior is that the plm_auto option optimizes the PML size such that the highest prime factors are low and thus optimize runtime.

@waltsims waltsims added the bug Something isn't working label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant